Add a full `fs.FS` implementation to `runfiles` #3969

fmeum · 2024-06-21T15:25:21Z

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Runfiles instances now implement fs.FS in a platform-agnostic way, regardless of whether they are manifest- or directory-based. This is meant to finally provide a full replacement for runfiles functionality offered by the legacy bazel package.

Which issues(s) does this PR fix?

Fixes #3375
Fixes #3830

Other notes for review

fmeum · 2024-06-24T14:15:01Z

cc @sluongng

sluongng

I gave this a quick read and have some nits, but this looks promising. FS is a powerful interface so I think this is the right approach.

go/runfiles/fs.go

go/runfiles/manifest.go

tests/runfiles/fs_test.go

sluongng

a few more nits

go/runfiles/manifest.go

fmeum · 2024-06-25T08:01:15Z

Thanks, I addressed your comments and am debugging the remaining test failure on Windows.

fmeum · 2024-06-25T08:24:15Z

The remaining test failure is a very reasonable one: The logic fails to account for runfiles that are linked under a basename that differs from that of the underlying file. This will require some more tweaks.

fmeum · 2024-07-09T12:27:26Z

@meteorcloudy The new macOS machines frequently run into timeouts: https://buildkite.com/bazel/rules-go-golang/builds/6622#01908e0d-57ff-4850-8b3c-cb9fe2fff52f

Are we perhaps lacking any settings?

meteorcloudy · 2024-07-09T12:44:17Z

@fmeum Yes, please check bazelbuild/continuous-integration#1981 (comment)

.bazelci/presubmit.yml

meteorcloudy · 2024-07-10T10:15:37Z

@fmeum To unblock this, you can also temporarily switch back to the old Mac fleet by using macos_legacy or macos_arm64_legacy.

The timeout looks weird, does it look like some network issue? One major difference is that the new Mac fleet is ipv6 only, not sure if it's relevant.

fmeum · 2024-07-10T10:26:50Z

@meteorcloudy Thanks, I'll go with this workaround for now until I can properly investigate this (limited to GitHub web UI right now).

The failing test downloads a few old Go releases from the official download page, I don't know why this would cause issues. The relevant tests are tagged local.

meteorcloudy · 2024-07-10T12:37:40Z

One major difference is that the new Mac fleet is ipv6 only, not sure if it's relevant.

Indeed it's caused by the ipv6-only network.

We are setting --host_jvm_args=-Djava.net.preferIPv6Addresses=true in /private/etc/bazel.bazelrc on the Mac VMs.
But it only affected the outer Bazel, inner Bazel running in the test has --nosystem_rc specified.
I can confirm after adding this flag in the go code, the three timeout tests are passing. Also on macos_arm64.

I'll let you decide how to inject this for macos ci, here is an example for Bazel's integration test bazelbuild/bazel@2c51a0c

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.48.1` -> `v0.49.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.49.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.49.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.48.1...v0.49.0) #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "d93ef02f1e72c82d8bb3d5169519b36167b33cf68c252525e3b9d3d5dd143de7", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.5") #### What's Changed - Add support for path mapping by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3915 - Introduce rules_go_unsupported_feature by [@cramertj](https://togithub.com/cramertj) in [bazelbuild/rules_go#3955 - Automatically run `bazel mod tidy` in `@rules_go//go` by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3927 - Fix revive warning in testmain.go files by [@EdSchouten](https://togithub.com/EdSchouten) in [bazelbuild/rules_go#3958 - Revert "feat(mode): add `purego` tag when `pure` ([#3901](https://togithub.com/bazelbuild/rules_go/issues/3901))" by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3961 - prepare patch release 0.48.1 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3963 - Fix broken link to https://bazel.build/concepts/dependencies#data-dependencies by [@alexbozhenko](https://togithub.com/alexbozhenko) in [bazelbuild/rules_go#3960 - docs: Discourage use `go_sdk.host()` in bzlmod.md (see [#713](https://togithub.com/bazelbuild/rules_go/issues/713)) by [@vorburger](https://togithub.com/vorburger) in [bazelbuild/rules_go#3968 - Add linux/ppc64le to GOARCH constraints by [@c16a](https://togithub.com/c16a) in [bazelbuild/rules_go#3975 - gopackagesdriver: Make kind query regexes anchored by [@jscissr](https://togithub.com/jscissr) in [bazelbuild/rules_go#3978 - Add a full `fs.FS` implementation to `runfiles` by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3969 - update readmes for latest release by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3988 - prepare release 0.49.0 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3989 #### New Contributors - [@cramertj](https://togithub.com/cramertj) made their first contribution in [bazelbuild/rules_go#3955 - [@alexbozhenko](https://togithub.com/alexbozhenko) made their first contribution in [bazelbuild/rules_go#3960 - [@vorburger](https://togithub.com/vorburger) made their first contribution in [bazelbuild/rules_go#3968 - [@c16a](https://togithub.com/c16a) made their first contribution in [bazelbuild/rules_go#3975 - [@jscissr](https://togithub.com/jscissr) made their first contribution in [bazelbuild/rules_go#3978 **Full Changelog**: bazelbuild/rules_go@v0.48.0...v0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.48.1` -> `v0.49.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.49.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.49.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.48.1...v0.49.0) #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "d93ef02f1e72c82d8bb3d5169519b36167b33cf68c252525e3b9d3d5dd143de7", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.5") #### What's Changed - Add support for path mapping by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3915 - Introduce rules_go_unsupported_feature by [@cramertj](https://togithub.com/cramertj) in [bazelbuild/rules_go#3955 - Automatically run `bazel mod tidy` in `@rules_go//go` by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3927 - Fix revive warning in testmain.go files by [@EdSchouten](https://togithub.com/EdSchouten) in [bazelbuild/rules_go#3958 - Revert "feat(mode): add `purego` tag when `pure` ([#3901](https://togithub.com/bazelbuild/rules_go/issues/3901))" by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3961 - prepare patch release 0.48.1 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3963 - Fix broken link to https://bazel.build/concepts/dependencies#data-dependencies by [@alexbozhenko](https://togithub.com/alexbozhenko) in [bazelbuild/rules_go#3960 - docs: Discourage use `go_sdk.host()` in bzlmod.md (see [#713](https://togithub.com/bazelbuild/rules_go/issues/713)) by [@vorburger](https://togithub.com/vorburger) in [bazelbuild/rules_go#3968 - Add linux/ppc64le to GOARCH constraints by [@c16a](https://togithub.com/c16a) in [bazelbuild/rules_go#3975 - gopackagesdriver: Make kind query regexes anchored by [@jscissr](https://togithub.com/jscissr) in [bazelbuild/rules_go#3978 - Add a full `fs.FS` implementation to `runfiles` by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3969 - update readmes for latest release by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3988 - prepare release 0.49.0 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3989 #### New Contributors - [@cramertj](https://togithub.com/cramertj) made their first contribution in [bazelbuild/rules_go#3955 - [@alexbozhenko](https://togithub.com/alexbozhenko) made their first contribution in [bazelbuild/rules_go#3960 - [@vorburger](https://togithub.com/vorburger) made their first contribution in [bazelbuild/rules_go#3968 - [@c16a](https://togithub.com/c16a) made their first contribution in [bazelbuild/rules_go#3975 - [@jscissr](https://togithub.com/jscissr) made their first contribution in [bazelbuild/rules_go#3978 **Full Changelog**: bazelbuild/rules_go@v0.48.0...v0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.48.1` -> `v0.49.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.49.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.49.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.48.1...v0.49.0) #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "d93ef02f1e72c82d8bb3d5169519b36167b33cf68c252525e3b9d3d5dd143de7", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.5") #### What's Changed - Add support for path mapping by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3915 - Introduce rules_go_unsupported_feature by [@cramertj](https://togithub.com/cramertj) in [bazelbuild/rules_go#3955 - Automatically run `bazel mod tidy` in `@rules_go//go` by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3927 - Fix revive warning in testmain.go files by [@EdSchouten](https://togithub.com/EdSchouten) in [bazelbuild/rules_go#3958 - Revert "feat(mode): add `purego` tag when `pure` ([#3901](https://togithub.com/bazelbuild/rules_go/issues/3901))" by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3961 - prepare patch release 0.48.1 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3963 - Fix broken link to https://bazel.build/concepts/dependencies#data-dependencies by [@alexbozhenko](https://togithub.com/alexbozhenko) in [bazelbuild/rules_go#3960 - docs: Discourage use `go_sdk.host()` in bzlmod.md (see [#713](https://togithub.com/bazelbuild/rules_go/issues/713)) by [@vorburger](https://togithub.com/vorburger) in [bazelbuild/rules_go#3968 - Add linux/ppc64le to GOARCH constraints by [@c16a](https://togithub.com/c16a) in [bazelbuild/rules_go#3975 - gopackagesdriver: Make kind query regexes anchored by [@jscissr](https://togithub.com/jscissr) in [bazelbuild/rules_go#3978 - Add a full `fs.FS` implementation to `runfiles` by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3969 - update readmes for latest release by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3988 - prepare release 0.49.0 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3989 #### New Contributors - [@cramertj](https://togithub.com/cramertj) made their first contribution in [bazelbuild/rules_go#3955 - [@alexbozhenko](https://togithub.com/alexbozhenko) made their first contribution in [bazelbuild/rules_go#3960 - [@vorburger](https://togithub.com/vorburger) made their first contribution in [bazelbuild/rules_go#3968 - [@c16a](https://togithub.com/c16a) made their first contribution in [bazelbuild/rules_go#3975 - [@jscissr](https://togithub.com/jscissr) made their first contribution in [bazelbuild/rules_go#3978 **Full Changelog**: bazelbuild/rules_go@v0.48.0...v0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.48.1` -> `v0.49.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.49.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.49.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.48.1...v0.49.0) #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "d93ef02f1e72c82d8bb3d5169519b36167b33cf68c252525e3b9d3d5dd143de7", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.5") #### What's Changed - Add support for path mapping by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3915 - Introduce rules_go_unsupported_feature by [@cramertj](https://togithub.com/cramertj) in [bazelbuild/rules_go#3955 - Automatically run `bazel mod tidy` in `@rules_go//go` by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3927 - Fix revive warning in testmain.go files by [@EdSchouten](https://togithub.com/EdSchouten) in [bazelbuild/rules_go#3958 - Revert "feat(mode): add `purego` tag when `pure` ([#3901](https://togithub.com/bazelbuild/rules_go/issues/3901))" by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3961 - prepare patch release 0.48.1 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3963 - Fix broken link to https://bazel.build/concepts/dependencies#data-dependencies by [@alexbozhenko](https://togithub.com/alexbozhenko) in [bazelbuild/rules_go#3960 - docs: Discourage use `go_sdk.host()` in bzlmod.md (see [#713](https://togithub.com/bazelbuild/rules_go/issues/713)) by [@vorburger](https://togithub.com/vorburger) in [bazelbuild/rules_go#3968 - Add linux/ppc64le to GOARCH constraints by [@c16a](https://togithub.com/c16a) in [bazelbuild/rules_go#3975 - gopackagesdriver: Make kind query regexes anchored by [@jscissr](https://togithub.com/jscissr) in [bazelbuild/rules_go#3978 - Add a full `fs.FS` implementation to `runfiles` by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3969 - update readmes for latest release by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3988 - prepare release 0.49.0 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3989 #### New Contributors - [@cramertj](https://togithub.com/cramertj) made their first contribution in [bazelbuild/rules_go#3955 - [@alexbozhenko](https://togithub.com/alexbozhenko) made their first contribution in [bazelbuild/rules_go#3960 - [@vorburger](https://togithub.com/vorburger) made their first contribution in [bazelbuild/rules_go#3968 - [@c16a](https://togithub.com/c16a) made their first contribution in [bazelbuild/rules_go#3975 - [@jscissr](https://togithub.com/jscissr) made their first contribution in [bazelbuild/rules_go#3978 **Full Changelog**: bazelbuild/rules_go@v0.48.0...v0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ride-app/payments-service).

fmeum force-pushed the runfiles-fs branch 7 times, most recently from c570027 to 8edd51e Compare June 24, 2024 09:31

fmeum changed the title ~~WIP: Add a full fs.FS implementation to runfiles~~ Add a full fs.FS implementation to runfiles Jun 24, 2024

fmeum force-pushed the runfiles-fs branch from 946c0d6 to 0b6a5cc Compare June 24, 2024 14:14

fmeum requested review from linzhp and tyler-french June 24, 2024 14:14

fmeum marked this pull request as ready for review June 24, 2024 14:14

fmeum force-pushed the runfiles-fs branch 2 times, most recently from e85435c to 67d7a60 Compare June 24, 2024 14:18

sluongng reviewed Jun 24, 2024

View reviewed changes

fmeum force-pushed the runfiles-fs branch from ca24e23 to 2d9ed97 Compare June 24, 2024 20:48

sluongng reviewed Jun 25, 2024

View reviewed changes

go/runfiles/manifest.go Outdated Show resolved Hide resolved

go/runfiles/manifest.go Outdated Show resolved Hide resolved

go/runfiles/manifest.go Outdated Show resolved Hide resolved

go/runfiles/manifest.go Outdated Show resolved Hide resolved

fmeum force-pushed the runfiles-fs branch from 7bbbcb4 to 4ac1eaa Compare June 25, 2024 07:55

fmeum force-pushed the runfiles-fs branch 2 times, most recently from d79da1c to 5603803 Compare June 25, 2024 08:23

fmeum force-pushed the runfiles-fs branch 2 times, most recently from b6e2352 to 86809bd Compare June 25, 2024 11:43

fmeum requested a review from sluongng June 25, 2024 14:13

fmeum force-pushed the runfiles-fs branch from 13d3cbb to a0f2648 Compare July 1, 2024 09:08

linzhp approved these changes Jul 7, 2024

View reviewed changes

fmeum added 2 commits July 7, 2024 16:35

WIP: Add a full fs.FS implementation to runfiles

5b7c637

Extract out common implementation

8b041e9

fmeum added 3 commits July 7, 2024 16:35

Add String() implementations and faithfully fake runfiles dir

6e37175

Resolve one layer of symlinks in directory impl

9345a46

Resolve all symlinks

6d1fcd4

fmeum force-pushed the runfiles-fs branch from a0f2648 to 6d1fcd4 Compare July 7, 2024 16:35

fmeum enabled auto-merge (squash) July 7, 2024 16:35

meteorcloudy mentioned this pull request Jul 9, 2024

Tracking issue for impact of 2024 MacOS fleet expansion bazelbuild/continuous-integration#1981

Closed

Update presubmit.yml

eec58b7

meteorcloudy reviewed Jul 9, 2024

View reviewed changes

.bazelci/presubmit.yml Outdated Show resolved Hide resolved

fmeum added 6 commits July 9, 2024 15:26

Update presubmit.yml

5b7cc84

Update BUILD.bazel

05af0ca

Update BUILD.bazel

c7a1c7a

Update BUILD.bazel

17b5094

Update BUILD.bazel

07aadcd

Update BUILD.bazel

724e678

fmeum added 5 commits July 10, 2024 10:24

Update presubmit.yml

43d6ff4

Update BUILD.bazel

27ba95b

Update BUILD.bazel

a2c43a7

Update BUILD.bazel

cc1de78

Update BUILD.bazel

db45c96

fmeum merged commit 3e84965 into master Jul 10, 2024
5 checks passed

fmeum deleted the runfiles-fs branch July 10, 2024 12:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a full `fs.FS` implementation to `runfiles` #3969

Add a full `fs.FS` implementation to `runfiles` #3969

fmeum commented Jun 21, 2024 •

edited

Loading

fmeum commented Jun 24, 2024

sluongng left a comment

sluongng left a comment

fmeum commented Jun 25, 2024

fmeum commented Jun 25, 2024

fmeum commented Jul 9, 2024

meteorcloudy commented Jul 9, 2024

meteorcloudy commented Jul 10, 2024

fmeum commented Jul 10, 2024

meteorcloudy commented Jul 10, 2024 •

edited

Loading

Add a full fs.FS implementation to runfiles #3969

Add a full fs.FS implementation to runfiles #3969

Conversation

fmeum commented Jun 21, 2024 • edited Loading

fmeum commented Jun 24, 2024

sluongng left a comment

Choose a reason for hiding this comment

sluongng left a comment

Choose a reason for hiding this comment

fmeum commented Jun 25, 2024

fmeum commented Jun 25, 2024

fmeum commented Jul 9, 2024

meteorcloudy commented Jul 9, 2024

meteorcloudy commented Jul 10, 2024

fmeum commented Jul 10, 2024

meteorcloudy commented Jul 10, 2024 • edited Loading

Add a full `fs.FS` implementation to `runfiles` #3969

Add a full `fs.FS` implementation to `runfiles` #3969

fmeum commented Jun 21, 2024 •

edited

Loading

meteorcloudy commented Jul 10, 2024 •

edited

Loading