support darwin_x86_64 cpu value #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@pmbethe09 this change is also needed in downstream dependency including buildifier, can we tag a release? |
|
@damienmg I'll cherry-pick this into a release on top of 0.4.3 today. |
jayconrod
pushed a commit
to jayconrod/rules_go
that referenced
this pull request
May 5, 2017
|
Thanks!
…On Fri, May 5, 2017 at 4:03 PM Jay Conrod ***@***.***> wrote:
@damienmg <https://github.com/damienmg> I'll cherry-pick this into a
release on top of 0.4.3 today.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#428 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADjHfwNaV7FBav93h6m15V176E_-aroWks5r2ywhgaJpZM4NOupY>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required as bazel CROSSTOOL intends on making "darwin_x86_64" the canonical default for osx systems going forward.