Split the pack and compile steps #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing tests because it requires the GOROOT changes in #434 to be submitted first |
jayconrod
approved these changes
May 4, 2017
go/def.bzl
Outdated
| Args: | ||
| ctx: The skylark Context. | ||
| out_lib: the archive that should be produced | ||
| objects: an iterable of object or archive files to be added to the output archive file. |
This changes the compile step to output a .o in all cases, and then use a subsequent pack step to build the .a This removes the last read modify write action from the bash scripts, and reduces the compile bash script to something we can retool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the compile step to output a .o in all cases, and then use a subsequent pack step to build the .a
This removes the last read modify write action from the bash scripts, and reduces the compile bash script to something we can retool