Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules_java > 7.2.0 incorrectly states it is compatible with Bazel >= 6.4.0 #159

Closed
SanjayVas opened this issue Dec 6, 2023 · 1 comment
Closed

rules_java > 7.2.0 incorrectly states it is compatible with Bazel >= 6.4.0 #159

SanjayVas opened this issue Dec 6, 2023 · 1 comment

Comments

@SanjayVas
Copy link

The bazel_compatibility attribute in MODULE.bazel contains >=6.4.0, but it is actually not compatible with 6.4.0. The last version that is compatible with 6.4.0 is rules_java@7.2.0.

See #151 (comment)
copybara-service bot pushed a commit that referenced this issue Dec 21, 2023
@hvadehra
Bump version to 7.3.2 for rules_java release
069da66 
BEGIN_PUBLIC

Bump version to 7.3.2 for rules_java release

Also bumps the bazel compatibility version (see #159)

END_PUBLIC

PiperOrigin-RevId: 592856710
Change-Id: I0dca14bc8057238158ed6d3a0e25f1f2443bc94c
@SanjayVas SanjayVas mentioned this issue Jan 9, 2024
Closed
@hvadehra
Copy link
Member

Fixed from v7.3.2 onwards

@vorburger vorburger mentioned this issue Jan 17, 2024
Closed
vorburger added a commit to vorburger/enola that referenced this issue Jan 17, 2024
@vorburger
chore(deps): Bump rules_java version from ? to 7.2.0
ae2db46 
Originally motivated by bazelbuild/bazel#18743,
in the context of salesforce/bazel-vscode-java#85,

but as noted in bazelbuild/rules_java#159
from enola-dev#427 I can't go to 7.3.2
just yet - but bumping at least already to 7.2.0 is a first step!
@vorburger vorburger mentioned this issue Jan 17, 2024
Merged
vorburger added a commit to vorburger/enola that referenced this issue Jan 17, 2024
@vorburger
chore(deps): Bump rules_java version from ? to 7.2.0
2dcb265 
Originally motivated by bazelbuild/bazel#18743,
in the context of salesforce/bazel-vscode-java#85,

but as noted in bazelbuild/rules_java#159
from enola-dev#427 I can't go to 7.3.2
just yet - but bumping at least already to 7.2.0 is a first step!
vorburger added a commit to enola-dev/enola that referenced this issue Jan 17, 2024
@vorburger
chore(deps): Bump rules_java version from ? to 7.2.0
37966d3 
Originally motivated by bazelbuild/bazel#18743,
in the context of salesforce/bazel-vscode-java#85,

but as noted in bazelbuild/rules_java#159
from #427 I can't go to 7.3.2
just yet - but bumping at least already to 7.2.0 is a first step!
JasonSteving99 added a commit to JasonSteving99/claro-lang that referenced this issue May 1, 2024
@JasonSteving99
Add Module Dep on rules_java to Update java_*() Rule Defs
24e5987 
Unfortunately, the presubmits for the latest PR to Bzlmod failed with some
mysterious Turbine error that's apparently been addressed by the latest
rules_java. It turns out that although Java support is built into Bazel,
you can separately update the java_* rule implementations without updating
to a later Bazel version by placing a Module dep on rules_java. This is new
info, but good to know. I chose rules_java@7.2.0 b/c apparently that's the
latest version that actually supports Bazel 6.4.0 which Claro currently targets.

- bazelbuild/bazel-central-registry#1901
- https://buildkite.com/bazel/bcr-presubmit/builds/5034#018f2bc7-7567-42c9-95df-814fc11b561c
- bazelbuild/rules_java#159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SanjayVas @hvadehra