Use Turbine native image as header_compiler_direct

[fmeum]

No description provided.

[fmeum]

@hvadehra @cushon This is ready for review.

[fmeum]

@keertk Sorry for all the hoops this requires, but could you create another rules_java release with this change?

[keertk]

Sure, it's here - https://github.com/bazelbuild/rules_java/releases/tag/7.3.0

[BoleynSu]

@fmeum this breaks rules_jvm_external with crashing here https://github.com/google/turbine/blob/33ed406f653ecfda611933103261a6ad3146dbd5/java/com/google/turbine/binder/CtSymClassBinder.java#L52. Could you take a look?

# a minimal repro
java_library(
    name = "l",
    srcs = ["t.java"],
    javacopts = [
        "--release",
        "8",
    ],
)

java_binary(
    name = "b",
    srcs = ["t.java"],
    main_class = "t.t",
    deps = [":l"],
)

[cushon]

@BoleynSu see bazelbuild/stardoc#195

[fmeum]

@BoleynSu rules_java 7.3.1 is out with the fix. Please give it a try.

[BoleynSu]

rules_java 7.3.1 seems to not fix the issue. I post it here after both the attempts to upgrade to 7.3.0 and 7.3.1 failed. Sent from https://boleyn.su/phone

…

On Sat, Dec 2, 2023, 14:34 Fabian Meumertzheim ***@***.***> wrote: @BoleynSu <https://github.com/BoleynSu> rules_java 7.3.1 is out with the fix. Please give it a try. — Reply to this email directly, view it on GitHub <#151 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXVSKB6UB5VFW7AAHMWGW3YHLDVTAVCNFSM6AAAAAA63CSJOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGA3DANJSGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[fmeum]

@BoleynSu That does sound like a problem with updating rules_java. How are you doing that?

With the following setup:

# BUILD
java_library(
    name = "l",
    srcs = ["t.java"],
    javacopts = [
        "--release",
        "8",
    ],
)

java_binary(
    name = "b",
    srcs = ["t.java"],
    main_class = "t.t",
    deps = [":l"],
)

# t.java
package t;

public class t {}

# MODULE.bazel
bazel_dep(name = "rules_java", version = "7.3.0")

I get:

$ USE_BAZEL_VERSION=7.0.0rc5 bazel build //:b
...
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
java.lang.NullPointerException: attempted to use --release, but JAVA_HOME is not set
	at java.base@20.0.2/java.util.Objects.requireNonNull(Objects.java:259)
	at com.google.turbine.binder.CtSymClassBinder.bind(CtSymClassBinder.java:52)
	at com.google.turbine.main.Main.bootclasspath(Main.java:309)
	at com.google.turbine.main.Main.compile(Main.java:142)
	at com.google.turbine.main.Main.compile(Main.java:133)
	at com.google.turbine.main.Main.main(Main.java:89)
Target //:b failed to build

When I update the rules_java version to 7.3.1, the build passes.

[BoleynSu]

I am still on Bazel 6.4.0. Maybe related? Sent from https://boleyn.su/phone

…

On Sat, Dec 2, 2023, 15:03 Fabian Meumertzheim ***@***.***> wrote: @BoleynSu <https://github.com/BoleynSu> That does sound like a problem with updating rules_java. How are you doing that? With the following setup: # BUILDjava_library( name = "l", srcs = ["t.java"], javacopts = [ "--release", "8", ], ) java_binary( name = "b", srcs = ["t.java"], main_class = "t.t", deps = [":l"], ) # t.javapackage t; public class t {} # MODULE.bazelbazel_dep(name = "rules_java", version = "7.3.0") I get: $ USE_BAZEL_VERSION=7.0.0rc5 bazel build //:b ... Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging java.lang.NullPointerException: attempted to use --release, but JAVA_HOME is not set at ***@***.***/java.util.Objects.requireNonNull(Objects.java:259) at com.google.turbine.binder.CtSymClassBinder.bind(CtSymClassBinder.java:52) at com.google.turbine.main.Main.bootclasspath(Main.java:309) at com.google.turbine.main.Main.compile(Main.java:142) at com.google.turbine.main.Main.compile(Main.java:133) at com.google.turbine.main.Main.main(Main.java:89) Target //:b failed to build When I update the rules_java version to 7.3.1, the build passes. — Reply to this email directly, view it on GitHub <#151 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXVSKDKQG7YQSNY552LZXTYHLHFXAVCNFSM6AAAAAA63CSJOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGA3DMNZUGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[fmeum]

Yes, Bazel 6.4.0 doesn't contain bazelbuild/bazel@4a29f08, which is needed to make the Java rules pass ct.sym to Turbine. I would recommend staying on rules_java 7.2.0 with Bazel 6.4.0.

[BoleynSu]

I see. I am skipping 7.3.x for now. BoleynSu-Org/monorepo@770b1fc
Hopefully, Bazel 7 can be used soon.