Fix can't install maven dependencies with top-level build directory

[cheister]

#1028

Just change the downloaded file path so it does not create a build directory when using http_file.

[shs96c]

Couldn't we just rename all our BUILD files to BUILD.bazel? That would avoid needing to do this work, and seems to be what is now common practice in the bazel OSS community (looking at the rulesets in bazel-contrib?

[cheister]

Couldn't we just rename all our BUILD files to BUILD.bazel? That would avoid needing to do this work, and seems to be what is now common practice in the bazel OSS community (looking at the rulesets in bazel-contrib?

This isn't a problem with a BUILD file we write, it's one generated by http_file and it checks if there is already a BUILD file in the path, on a case-insensitive file system it compares the build/ directory to BUILD and fails. So the workaround is to not have build/ in the downloaded_file_path passed to http_file

[shs96c]

LGTM. Thanks for the clarification. I'd missed that entirely

[cheister]

Should also address #970