Allow bazel run @maven//:pin to run successfully
#426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do this, we download each version of jq that might be used and ensure it's available. Decide at run time which version we'll use.
|
Hmm, this isn't working for me Changing this arg We go to lengths to genrule-copy the file to just "jq" so it doesn't seem like we should have to do this? unless it's for windows, but then you still don't have a bash.runfiles helper used in the pin.sh script |
alexeagle
pushed a commit
to alexeagle/rules_jvm_external
that referenced
this pull request
Sep 2, 2020
Problem reported on bazel-contrib#426 The build typically takes place in the user's workspace, so using `$(location)` (or more correctly, `$(rootpath)`) gives an undesirable "external/" leading segment. This would be useful if the binary being run is in the users workspace, but we know our binary is in the same workspace defining the BUILD file. This change also uses the runfiles helper since I think that's required to make this work on Windows, though I only tested on Mac.
alexeagle
pushed a commit
to alexeagle/rules_jvm_external
that referenced
this pull request
Sep 2, 2020
Problem reported on bazel-contrib#426 The build typically takes place in the user's workspace, so using `$(location)` (or more correctly, `$(rootpath)`) gives an undesirable "external/" leading segment. This would be useful if the binary being run is in the users workspace, but we know our binary is in the same workspace defining the BUILD file. This change also uses the runfiles helper since I think that's required to make this work on Windows, though I only tested on Mac.
alexeagle
pushed a commit
to alexeagle/rules_jvm_external
that referenced
this pull request
Sep 9, 2020
It currently relies on the legacy_external_runfiles behavior where Bazel makes two copies of the program, at both pin.runfiles/unpinned_maven/jq and pin.runfiles/user_repo/external/unpinned_maven/jq Problem reported on bazel-contrib#426
alexeagle
pushed a commit
to alexeagle/rules_jvm_external
that referenced
this pull request
Sep 9, 2020
It currently relies on the legacy_external_runfiles behavior where Bazel makes two copies of the program, at both pin.runfiles/unpinned_maven/jq and pin.runfiles/user_repo/external/unpinned_maven/jq Problem reported on bazel-contrib#426
shs96c
pushed a commit
that referenced
this pull request
Sep 9, 2020
It currently relies on the legacy_external_runfiles behavior where Bazel makes two copies of the program, at both pin.runfiles/unpinned_maven/jq and pin.runfiles/user_repo/external/unpinned_maven/jq Problem reported on #426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this, we download each version of jq that might be used and
ensure it's available. Decide at run time which version we'll use.
Fixes #409