Use argsfile for java if we are using java 9 or higher to avoid command line length limits #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jin
approved these changes
Aug 16, 2021
| exec_result = _execute(repository_ctx, [java_path, "-version"]) | ||
| if (exec_result.return_code != 0): | ||
| fail("Error while running java -version: " + exec_result.stderr) | ||
| if parse_java_version(exec_result.stdout + exec_result.stderr) > 8: |
There was a problem hiding this comment.
Is the output of java -version on both stdout and stderr?
There was a problem hiding this comment.
It looks like it goes to stderr in the two cases I tried but I wasn't sure if that would be the case for all jvm versions.
…nd line length limits
cheister
force-pushed
the
java-argsfile
branch
from
2a2a873
to
3073716
Compare
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #549 if they are using Java 9 or higher