java_export: set default testonly = None #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testonly=False overrides packages' default_testonly value unnecessarily
tsawada
requested review from
jin,
c-parsons,
shs96c and
cheister
as code owners
|
ping? It'd be great if this could be merged before the next release. |
jin
approved these changes
Apr 28, 2022
|
@jin thanks for your review. is there anything I need to do to get this merged? |
|
The failure seems to be related to #677, which is already merged. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup for #674.
I noticed that having
testonly=Falseby default overrides packages'default_testonlyvalue unnecessarily.