Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hard-coding -source 8 -target 8 #681

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Apr 18, 2022

And instead compile with whatever the default --tool_java_language_version is. Explicitly specifying a language level for individual targets should be unecessary.

I noticed this debugging bazelbuild/bazel#15272

And instead compile with whatever the default
`--tool_java_language_version` is. Explicitly specifying a language
level for individual targets should be unecessary.
@cheister
Copy link
Collaborator

Should --tool_java_language_version be added to .bazelrc as well to make sure we're building Java 8 jars?

@cushon
Copy link
Contributor Author

cushon commented Apr 20, 2022

Why not just use the --tool_java_language_version? Is there anything about these tools that wouldn't be compatible with newer language levels?

@shs96c
Copy link
Collaborator

shs96c commented Apr 29, 2022

We should be able to land this safely enough. Let's see what happens.

Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We originally did this to ensure that we weren't accidentally using Java 8 features, since that's what Bazel was using. Given that this code is stable now, and Bazel itself uses Java 11, this should be fine.

@shs96c shs96c merged commit 2286790 into bazel-contrib:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants