Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] apoption support for KSP plugins #1104

Open
xinzhengzhang opened this issue Jan 20, 2024 · 5 comments
Open

[Feature Request] apoption support for KSP plugins #1104

xinzhengzhang opened this issue Jan 20, 2024 · 5 comments

Comments

@xinzhengzhang
Copy link

xinzhengzhang commented Jan 20, 2024

In some ksp usage scenarios, you need to pass in apoption. But now rules does not implement this function.
I tried to implement it with a options params. #1103
Here's how it's used.

kt_ksp_plugin(
    name = "kotlin-native-coroutine-ksp",
    processor_class = "",
    deps = [
        "@maven//:com_rickclephas_kmp_kmp_nativecoroutines_ksp",
        "@maven//:com_rickclephas_kmp_kmp_nativecoroutines_annotations_jvm",
        "@maven//:com_rickclephas_kmp_kmp_nativecoroutines_core_jvm"
    ],
    options = {
        "nativeCoroutines.suffix" : "Native",
        "nativeCoroutines.flowValueSuffix": "Value",
        "nativeCoroutines.flowReplayCacheSuffix": "ReplayCache",
        "nativeCoroutines.stateSuffix": "Value",
        "nativeCoroutines.stateFlowSuffix": "Flow",
    },
    visibility = ["//visibility:public"],
)
@xinzhengzhang xinzhengzhang changed the title [Feature Request] apopts support for KSP plugins [Feature Request] apoption support for KSP plugins Jan 20, 2024
@idanakav
Copy link

See #1036 , it was never merged, we use it internally with no issues.

@Bencodes
Copy link
Collaborator

We use #1036 internally as well.

@xinzhengzhang
Copy link
Author

I would like to ask if #1036 will be merged? It seems that the last update of this was last October

@pswaminathan
Copy link
Contributor

We would also be very interested in a release with #1036 merged.

@valeraz
Copy link

valeraz commented Sep 24, 2024

+1 to request for this support.

@ahumesky any chance we could get the priority of this one bumped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants