Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License requirements #37

Open
ulfjack opened this issue May 11, 2022 · 0 comments
Open

License requirements #37

ulfjack opened this issue May 11, 2022 · 0 comments

Comments

@ulfjack
Copy link
Contributor

ulfjack commented May 11, 2022

I just wanted to move our requirements from a comment on a closed PR (#6 (comment)) to the bugtracker:

  • it didn't collect through output file dependencies (fixed now)
  • we have a custom license type that also has attached file references to license and notice files as well as URLs pointing at the original source (this information is required for some cloud marketplace deployments)
  • the list of attributes it traverses is too narrow; it's actually hard to come up with a complete list, but here's what we're using for a Java application: "deps", "exports", "jars", "resources", "runtime_deps", "srcs"; for other languages, we may need to collect from even more attributes (e.g., hdrs for C++)
  • it doesn't enforce our repo-specific annotation rules: we're enforcing license annotations for all rules under our third_party directory and a subset of external workspaces; some of that is specific to our use case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant