-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR]: Separate toolchain for for C++ headers #3722
Comments
A specific use case that is broken by this is embedding a |
Hmm can this be optional/lazy somehow? Having it be a separate toolchain might end up with it not matching the selected target toolchain. I'm surprised we haven't heard similar issues with py_binary, I think it's the same setup? |
py_runtime doesn't contain a label to a Although there is a similar issue in bazelbuild/bazel#8751 that causes a |
One option would be
|
@jesses-canva That's an interesting idea! I gave it a shot, but there's one wrinkle - we need to figure out the right |
This issue has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs in 30 days. Note as of rules_nodejs v6 the rules_nodejs repository contains only the core nodejs toolchain and |
Not stale |
I'm going to be looking at this this week to make this fix before rules_js 2.0 final so if it needs to be breaking for some use cases we can update the minimum dep in the rules_js 2.0 final release |
Fix landed and released with https://github.com/bazelbuild/rules_nodejs/releases/tag/v6.2.0 |
What is the current behavior?
As of #3694 the
NodeInfo
provider includesCcInfo
for the NodeJS N-API headers.While useful for native addon development, this made the
node_toolchain
depend on the C++ toolchain as thatCcInfo
instance is pulled from thecc_library
target:headers
.For workflows that don't need those headers, they incur the penalty of fetching the C++ toolchain. This can play out as;
nixpkgs_cc_configure
from https://github.com/tweag/rules_nixpkgs)Describe the feature
Introduce a separate toolchain targeted at native addon development so that plain JS workflows do not implicitly depend on C++ toolchains.
The text was updated successfully, but these errors were encountered: