feat(less): new less package #1017
Conversation
joshvanallen
requested review from
alexeagle,
gregmagolan and
kyliau
as code owners
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
e2e/less/package.json
Outdated
| "name": "e2e-less", | ||
| "private": true, | ||
| "devDependencies": { | ||
| "@bazel/less": "file:../../dist/bin/packages/less/npm_package" |
There was a problem hiding this comment.
this can be "latest" - after we push the first time, the e2e directory will be self-contained
packages/less/src/index.bzl
Outdated
| doc = """Label that points to the lessc binary to run. | ||
| If you install your npm packages to a workspace named something other than "npm", | ||
| you may need to set this to `@my_npm_name//less/bin:lessc`""", | ||
| default = Label("@npm//less/bin:lessc"), |
There was a problem hiding this comment.
Should be default = Label("@npm//@bazel/less/bin:less"), so by default it uses the index.js file in the npm package and requires the version of less that @bazel/less depends on and not a user version by mistake
Other information
Feature was requested in angular/angular#19058 and myself.
I saw @alexeagle made a pull request for Less support and one of the comments was support for
include-paths. According to Alex, it seem that feature isn't needed as it'll be eventually deprecated as well in the Sass rules eventually so I didn't include it in this implementation.I didn't include
compressas an option either because, according to Less's documentation, it is currently deprecated.