Fix pkg_tar to not add the ./ to the prefix of every member. #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jylinv0
reviewed
Mar 3, 2022
jylinv0
reviewed
Mar 3, 2022
jylinv0
reviewed
Mar 3, 2022
Fixes: bazelbuild#531 - Remove leading './' from merged tar files. Also applies to pkg_deb. - Remove package_base from pkg_tar. Closes bazelbuild#549 - Use build_tar --directory as the prefix to add to everything. Note that the code is intentionaly not testing use cases that try to add "./" as an explicit root. This might still work, but it is a bad idea, for the reasons described in bazelbuild#531 . If someone comes up with a real need for using a leading "./" AND it does not work, they can file a feature request to support it.
aiuto
added a commit
to aiuto/rules_pkg
that referenced
this pull request
Mar 4, 2022
Closes bazelbuild#404 While adding tests to make sure we actually could strip it with pkg_files, I discovered a deficiency in pkg_tar_test. It was not doing a check on the file names, only content and type. Fixing that exposed a pre-existing bug. Fortunately, the problem uncovered is fixed by bazelbuild#554, so the tests should pass once that, followed by this PR are submitted. Allow pkg_files.strip_prefix to work on tree artifact without having to use `renames`. Update to 0.7.0 to reflect that this is sort of a big behavioral change.
aiuto
added a commit
to aiuto/rules_pkg
that referenced
this pull request
Mar 4, 2022
Closes bazelbuild#404 While adding tests to make sure we actually could strip it with pkg_files, I discovered a deficiency in pkg_tar_test. It was not doing a check on the file names, only content and type. Fixing that exposed a pre-existing bug. Fortunately, the problem uncovered is fixed by bazelbuild#554, so the tests should pass once that, followed by this PR are submitted. Allow pkg_files.strip_prefix to work on tree artifact without having to use `renames`. Update to 0.7.0 to reflect that this is sort of a big behavioral change.
jylinv0
approved these changes
Mar 4, 2022
aiuto
added a commit
that referenced
this pull request
Mar 6, 2022
Closes #404 While adding tests to make sure we actually could strip it with pkg_files, I discovered a deficiency in pkg_tar_test. It was not doing a check on the file names, only content and type. Fixing that exposed a pre-existing bug. Fortunately, the problem uncovered is fixed by #554, so the tests should pass once that, followed by this PR are submitted. Allow pkg_files.strip_prefix to work on tree artifact without having to use `renames`. Update to 0.7.0 to reflect that this is sort of a big behavioral change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #531
Note that the code is intentionaly not testing use cases that try to add "./"
as an explicit root. This might still work, but it is a bad idea, for the
reasons described in #531 . If someone comes up with a real need for
using a leading "./" AND it does not work, they can file a feature
request to support it.