Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write debian changes Date field in UTC rather than local time #712

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

aiuto
Copy link
Collaborator

@aiuto aiuto commented Jun 27, 2023

This fixes some subtle problems caused by having CI and developer machines in different time zones.
It's also the right thing.

@aiuto aiuto requested review from sdtwigg and tetromino and removed request for dannysullivan and jylinv0 June 27, 2023 15:22
@aiuto
Copy link
Collaborator Author

aiuto commented Jun 27, 2023

@tetromino was pkg_deb_test one of the rules_pkg things broken at head?

@aiuto
Copy link
Collaborator Author

aiuto commented Jun 27, 2023

Very strange. Now the tests are failing on mac because of some strange unicode handling of the Description field.
Do you know if we changed the python versions on buildkite recently?

@aiuto aiuto requested a review from nacl as a code owner June 27, 2023 16:31
@tetromino
Copy link
Contributor

I can reproduce this in local testing on my Macbook with Bazel HEAD; everything worked fine with 6.2.1

rules_pkg python code is correct AFAICT.

Something in Bazel at HEAD broke argument encoding in spawned processes on macOS :/

@tetromino
Copy link
Contributor

bazelbuild/bazel#18792 - update to JDK 20 broke non-ascii argument encoding on macOS.

@sdtwigg
Copy link

sdtwigg commented Jun 28, 2023

I think I should insist you squash these commits into one commit.

@aiuto
Copy link
Collaborator Author

aiuto commented Jun 29, 2023

I think I should insist you squash these commits into one commit.

That rebase is tricky. It fails on each squashed change and I have to hand edit. The merge squashes it.
That is, when I merge things the repo default is squash mode. I edit the comments down to one single one that makes sense. This is the only thing that makes sense. I don't know why other merges are even possible.

@aiuto
Copy link
Collaborator Author

aiuto commented Jun 29, 2023

Oh... the tests are failing for orthogonal reasons..

@aiuto
Copy link
Collaborator Author

aiuto commented Jun 29, 2023

I rebased it down. You can't tell in the github UI though.

@tetromino
Copy link
Contributor

For me in manual testing, after bazelbuild/bazel@f00439d, //tests/deb:pkg_deb_test passes on macOS.

But it still fails on the CI machine at the exact same git commit :/

@aiuto aiuto merged commit a40a8f4 into bazelbuild:main Jul 4, 2023
2 checks passed
@aiuto aiuto deleted the ddd branch July 4, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants