Addressed clippy warnings from clippy 0.1.67 (ec56537c 2022-12-15)

[UebelAndre]

This PR addresses newer clippy warnings that exist in nightly toolchains. #1712 introduces regression testing for this change but since it's larger change I thought it made sense to review separately.

[illicitonion]

I think this is generally reasonable, but, it does restrict rules_rust support to only rust versions 1.58.0 (released January 2022) and newer. Specifically because the process wrapper will now be using a construct only supported since that release.

If we care about supporting older rusts, we should probably disable this particular lint in the process_wrapper and revert the changes in that one binary.

I personally am fine with dropping support for year-old rusts, but also if someone else does care, I don't think slightly-cleaner-format-strings is a valuable enough feature to justify breaking support for older rusts.

[UebelAndre]

I think this is generally reasonable, but, it does restrict rules_rust support to only rust versions 1.58.0 (released January 2022) and newer. Specifically because the process wrapper will now be using a construct only supported since that release.

If we care about supporting older rusts, we should probably disable this particular lint in the process_wrapper and revert the changes in that one binary.

I personally am fine with dropping support for year-old rusts, but also if someone else does care, I don't think slightly-cleaner-format-strings is a valuable enough feature to justify breaking support for older rusts.

I would agree some formatting fixes would be an upsetting thing to change the min supported version for. However, before making that change I wanted to know what the min version there repo supported was so I opened #1720 and found issues on versions less than 1.59.0. I only stopped at one and haven't looked to see if there's a work-around. I posted the error on the following comment and think we should discuss that there: #1720 (comment)

[illicitonion]

Works for me - ship it!