Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: X-Pagination nextPageLink #2

Closed
bpkinez opened this issue Feb 15, 2018 · 3 comments
Closed

Bug: X-Pagination nextPageLink #2

bpkinez opened this issue Feb 15, 2018 · 3 comments

Comments

@bpkinez
Copy link
Contributor

bpkinez commented Feb 15, 2018

Hi Benjamin,

when I send request e.g. http://localhost:51607/api/user?filter=FirstName!=Veronica, I noticed that library is generating X-Pagination nextPageLink as http://localhost:51607/api/User?pageNumber=2&pageSize=5&filter=FirstName!%3Dveronica with %3D instead of = character.

It would be nice when characters would not be URL encoded (Percent Encoded).

Thanks,
Branislav

@bbartels
Copy link
Owner

I wondered about this as well, but could not find a satisfying answer online on how to go about fixing it.
I have a suspicion it is linked to this github issue.
I might just add some middle-ware that replaces the percent-encoded characters after generation.

@bpkinez
Copy link
Contributor Author

bpkinez commented Feb 15, 2018

Custom middleware seems to me a good temporary fix to this issue.

Thanks.

@bbartels
Copy link
Owner

Fixed in 7a45091.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants