[Fix #1500] Add support for recursive project discovery #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juergenhoetzel
force-pushed
the
recursive-project-discovery
branch
from
9ce7ed9
to
c60c9c0
Compare
|
The suggested change seems reasonable, although it definitely has to be documented, otherwise I doubt that anyone will ever discover it. |
bbatsov
reviewed
Jun 28, 2021
| (when (and (file-directory-p dir) (projectile-project-p dir)) | ||
| (projectile-add-known-project dir))) | ||
| subdirs)) | ||
| (let ((subdirs (directory-files directory t))) |
There was a problem hiding this comment.
The indentation after the let looks off. I assume you wanted to nest that dolist.
juergenhoetzel
force-pushed
the
recursive-project-discovery
branch
from
c60c9c0
to
0fc2a1f
Compare
Extend type of `projectile-project-search-path` to allow elements of form (DIRECTORY . DEPTH) to discover projects at the specified depth.
juergenhoetzel
force-pushed
the
recursive-project-discovery
branch
from
0fc2a1f
to
003f938
Compare
|
good points addressed: I amended the commit and added changelog/usage sections. |
|
Thanks! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend type of
projectile-project-search-pathto allow elements ofform (DIRECTORY . DEPTH) to discover projects at the specified depth.
eldev test)M-x checkdocwarningsThanks!