Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch rails-rspec src-dir #1781

Merged
merged 1 commit into from Jun 26, 2022
Merged

Switch rails-rspec src-dir #1781

merged 1 commit into from Jun 26, 2022

Conversation

lackita
Copy link
Contributor

@lackita lackita commented Jun 18, 2022

Rails puts most of its source files under app rather than lib. This
updates the src-dir to allow easy switching between source and test
files in this case.


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@bbatsov
Copy link
Owner

bbatsov commented Jun 23, 2022

Makes sense. I guess we should do the same for rails-minitest as well.

@lackita
Copy link
Contributor Author

lackita commented Jun 26, 2022

Good call, I'll try to change that tomorrow

Rails puts most of its source files under app rather than lib. This
updates the src-dir to allow easy switching between source and test
files in this case.
@lackita
Copy link
Contributor Author

lackita commented Jun 26, 2022

Alright, I think that's all set now. Let me know if you want me to change anything else.

@bbatsov bbatsov merged commit 8f2e1ea into bbatsov:master Jun 26, 2022
@bbatsov
Copy link
Owner

bbatsov commented Jun 26, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants