[#1148] Don't show deleted files in listing #1825
Conversation
When fd is installed, use it with appropriate options instead of git ls-files in order to fix bbatsov#1148
|
No test or README updates made because this type of functionality was not previously present in test framework or README. However, if it would help out the project, I don't mind making updates for one or both to start them off. |
| @@ -7,6 +7,10 @@ | |||
| * Add elm project type. | |||
| * [#1821](https://github.com/bbatsov/projectile/pull/1821): Add `pyproject.toml` discovery for python projects. | |||
|
|
|||
| ### Changes | |||
|
|
|||
| * [#1285](https://github.com/bbatsov/projectile/pull/1825): By default, use [fd](https://github.com/sharkdp/fd) in Git repositories instead of `git ls-files` when it is installed, in order to solve the problem where deleted files were still shown in `projectile-find-file` until their deletions were staged. The user-facing behavior should be the same, although potentially with different performance characteristics in large Git repositories. The old behavior can be reclaimed by setting `projectile-git-use-fd` to nil. | |||
There was a problem hiding this comment.
I'd also make a note of this in the docs (probably somewhere in usage and in the FAQ).
There was a problem hiding this comment.
Just realized there is a separate usage page apart from the readme. It already says fd is used when possible and installed, shall I add more detail about how Projectile determines which tool to use?
There was a problem hiding this comment.
Yeah, I guess that'd be a nice addition to the docs.
| "Arguments to fd used to re-implement `git ls-files'. | ||
| This is used with `projectile-fd-executable' when `projectile-git-use-fd' | ||
| is non-nil." | ||
| :group 'projectile |
There was a problem hiding this comment.
This one should have a :package-version as well.
There was a problem hiding this comment.
Sorry, b68f7ef
|
Looks like CI is failing with: at e.g. https://github.com/bbatsov/projectile/actions/runs/4299885959/jobs/7495540856 I don't think that's related to this change. I'm happy to help troubleshoot that if it would be helpful. |
|
Looks like the above error was resolved, however snapshot build is failing with: at e.g. https://github.com/bbatsov/projectile/actions/runs/4394757932/jobs/7695987087 Again I don't think it's related to this change, but happy to help troubleshoot. |
|
Thanks for working on this. I'll check the CI problem myself at some point. |
When fd is installed, use it with appropriate options instead of git ls-files in order to fix #1148.
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)M-x checkdocwarningsThanks!