Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fd: explicitly disable colors #1859

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fd: explicitly disable colors #1859

merged 1 commit into from
Sep 19, 2023

Conversation

kurnevsky
Copy link
Contributor

Currently fd uses auto mode which inserts colors when used over tramp.

Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@kurnevsky
fd: explicitly disable colors
cde7da4 
Currently fd uses auto mode which inserts colors when used over tramp.
@bbatsov bbatsov merged commit d24b817 into bbatsov:master Sep 19, 2023
5 of 6 checks passed
@bbatsov
Copy link
Owner

bbatsov commented Sep 19, 2023

Thanks!

noisycomputation added a commit to noisycomputation/doom-emacs that referenced this pull request Oct 11, 2023
@noisycomputation
fix(projectile): disable colors in fd invocation
19333cf 
bbatsov/projectile@971cd5c4f25f -> batsov/projectile@d24b8173223f

The pinned `projectile` version erroneously calls `fd` without
explicitly disabling colors, which inserts color terminal codes
into filenames when used over `tramp`. This completely breaks
projectile over `tramp`.

The linked change adds `-c never` (shorthand form of `--color=never`)
to `projectile-git-fd-args`. This is the only change in `projectile`
between the two versions linked above, and it completely resolves
the issue.

Ref: bbatsov/projectile#1860
Ref: bbatsov/projectile#1859
noisycomputation added a commit to noisycomputation/doom-emacs that referenced this pull request Oct 11, 2023
@noisycomputation
fix(projectile): disable colors in fd invocation
7584f3b 
bbatsov/projectile@971cd5c4f25f -> bbatsov/projectile@d24b8173223f

The pinned `projectile` version erroneously calls `fd` without
explicitly disabling colors, which inserts color terminal codes
into filenames when used over `tramp`. This completely breaks
projectile over `tramp`.

The linked change adds `-c never` (shorthand form of `--color=never`)
to `projectile-git-fd-args`. This is the only change in `projectile`
between the two versions linked above, and it completely resolves
the issue.

Ref: bbatsov/projectile#1860
Ref: bbatsov/projectile#1859
@noisycomputation noisycomputation mentioned this pull request Oct 11, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kurnevsky @bbatsov