New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project types "yarn" and "pnpm" separate from "npm" #1862

Merged

bbatsov merged 4 commits into bbatsov:master from knu:npm_project_types

Sep 19, 2023

Contributor

knu commented Sep 16, 2023 •

edited

Loading

Yarn and pnpm are two popular alternatives to npm and you can tell which is used in a project by the existence of their respective lock files.

Plus, the build script is worth being a default "compile" command for npm-based projects.

The commits are consistent with our contribution guidelines
You've added tests (if possible) to cover your change(s)
All tests are passing (eldev test)
The new code is not generating bytecode or M-x checkdoc warnings
You've updated the changelog (if adding/changing user-visible functionality)
You've updated the readme (if adding/changing user-visible functionality)

knu added 4 commits

September 16, 2023 17:35


          Add a new project type "yarn" separate from "npm"

ad1f2b2


          Perform npm run build as the compile command for npm projects

ade266d


          Add a new project type "pnpm"

779007d


          Update CHANGELOG.md

47fae06

bbatsov merged commit eaf2644 into bbatsov:master

5 of 6 checks passed

Owner

bbatsov commented Sep 19, 2023

Looks good. Thanks!

knu deleted the npm_project_types branch

September 19, 2023 06:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment