Add category metadata to completing-read #1892
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the metadata only to the default Emacs
completing-read
. as I am not familiar with the 3rd party systems helm and ivy.eldev test
)M-x checkdoc
warningsI'm not sure about checking the last 2 checkboxes. The changes are only visible if using third-party packages like
marginalia and embark which use the metadata.
projectile-switch-project
without metadata:with metadata:
![image](https://private-user-images.githubusercontent.com/52547/333900444-6880a342-69c0-48b8-bb86-314200cf3ad9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2NjkxMTYsIm5iZiI6MTcxOTY2ODgxNiwicGF0aCI6Ii81MjU0Ny8zMzM5MDA0NDQtNjg4MGEzNDItNjljMC00OGI4LWJiODYtMzE0MjAwY2YzYWQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDEzNDY1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA5MDg3NDQyNWM2NDQ5OTE1YzdlODMxZjAyOTE4MDY5NGQwYzg0MjA5MTMzZGU5YTFkMWU3ZDdkOGZlYzliNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2_RmN9FgKvMA00L4paFyDOd6ylN6vZ4Ywp4AYEYcekQ)