Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving subversion support. #285

Merged
merged 1 commit into from Mar 17, 2014
Merged

Improving subversion support. #285

merged 1 commit into from Mar 17, 2014

Conversation

Wilfred
Copy link
Contributor

@Wilfred Wilfred commented Mar 13, 2014

This ensures that .svn directories are ignored, and we use subversion's
list command to get files for performance.

This ensures that .svn directories are ignored, and we use subversion's
list command to get files for performance.
@bbatsov
Copy link
Owner

bbatsov commented Mar 14, 2014

Looks good. The .svn dirs were ignored recursively, right? I wonder why I haven't include .svn and CVS here originally. Perhaps this was for only a top-level check back then.

@Wilfred
Copy link
Contributor Author

Wilfred commented Mar 17, 2014

Yep, they're ignored recursively. Are you happy with this PR? I'm happy to make changes if not.

bbatsov added a commit that referenced this pull request Mar 17, 2014
Improving subversion support.
@bbatsov bbatsov merged commit 355c136 into bbatsov:master Mar 17, 2014
@Wilfred
Copy link
Contributor Author

Wilfred commented Mar 17, 2014

Thanks! :)

@bbatsov
Copy link
Owner

bbatsov commented Mar 17, 2014

No, it's fine as it is. Thanks!

Hopefully someday subversion projects will be recognized automatically, but I don't use svn anymore and I don't have time to implement that.

@Wilfred
Copy link
Contributor Author

Wilfred commented Mar 18, 2014

I've actually got an implementation of subversion project root detection: Wilfred/repo-root.el@70ca866 . Happy to send another PR.

By the way, would there be any interest in separating out the 'detect the root of this repo' code as a separate package? I have several packages that would really find the functionality useful, but I'm reluctant to pull in all of projectile as a dependency.

@bbatsov
Copy link
Owner

bbatsov commented Mar 18, 2014

Sure, I'd take a PR for this. Didn't know it was implemented in vc.el.

As for the separate package - I've considered this myself (since I've needed similar code elsewhere), but I haven't gotten to actually doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants