Change the caching of remote configs to live alongside the parent file #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
The change looks good, but it needs a changelog entry. |
Fryguy
force-pushed
the
cache_remote_urls_in_one_place
branch
from
9d460f1
to
2493a6f
Compare
|
@bbatsov Changelog updated. |
|
👍 |
1 similar comment
|
👍 |
bbatsov
added a commit
that referenced
this pull request
Mar 4, 2016
Change the caching of remote configs to live alongside the parent file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user
cds into a different directory, then the cached file for inherit_from with a remote URL would live in that directory. This PR changes that to have it live alongside the rubocop.yml that defined the inherit_from.This issue affected me in an interesting way in that I use SublimeLinter to run rubocop in Sublime Text. I believe SublimeLinter must be
cding to the directory of the file in question, and so the inherit_from caching of remote URLs is littering my directory structure with .rubocop-http---example-com-rubocop-yml files. With this change the user can just .gitignore the one cache file.I've spoken to vim users using syntastic, and they have same problem as well. If they cd into a directory and then start vim from that directory, then the cache file will live there, ultimately littering a number of directories.