Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make configurable Style/MultilineMemoization cop #4019

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented Feb 5, 2017

Currently, Style/MultilineMemoization cop is not configurable.
This change makes configurable this cop.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@pocke pocke force-pushed the enforced-style-multiline-memoization branch from d494213 to f7e0806 Compare February 5, 2017 08:23
@@ -3,11 +3,12 @@
module RuboCop
module Cop
module Style
# This cop checks that multiline memoizations are wrapped in a `begin`
# and `end` block.
# This cop checks wrapped styles for multiline memoization.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrapped styles -> expressions wrapping styles

@pocke pocke force-pushed the enforced-style-multiline-memoization branch 2 times, most recently from cce93f3 to 77b24ec Compare February 6, 2017 07:47
Currently, `Style/MultilineMemoization` cop is not configurable.
This change makes configurable this cop.
@pocke pocke force-pushed the enforced-style-multiline-memoization branch from 77b24ec to 812b9d8 Compare February 6, 2017 07:50
@pocke
Copy link
Collaborator Author

pocke commented Feb 6, 2017

Thanks for your review. I've fixed the message.

@bbatsov bbatsov merged commit dd94c4d into rubocop:master Feb 6, 2017
@pocke pocke deleted the enforced-style-multiline-memoization branch February 6, 2017 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants