-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid side effects on install/build #325
Comments
What side effect you seen? You tell me more information, I can try work on it. |
It applied facedefs while byte compiling/loading the -theme files, idk if it was fixed or not.. Not really a big practical issue. I havent seen it myself for many years IIRC, I don't know what you have to do to experience it as a problem.
|
I encountered the same problem, run the code snippet below:
The I am writing a theme switch tool which loaded all themes but didn't enable any
Many popular themes are works well, except |
When you run Now, the original issue was that there were side effects when update/install (maybe at byte-compiling). The thread owner and you reported are different. |
I have a feeling that It seems like we could change the order of child theme and base solarized face defs are run but I'm not sure if that causes other unwanted scenarios instead (base anc child facesdes not being merged?). I have a feeling that the proper solution would be to write code that merges I am not sure I want to make invasive changes to how that works right now since we just change it recently so if we are going to resolve it now it has to be compatible with how child themes are set up now. |
You can probably work around the issue at by unloading the theme again after loading it. IIRC that removes any faces applied during the load theme phase regardless of how it's set. It will probably still flash new faces temporarily, maybe it's possible to inhibit fontification (or whatever applies faces to displays) while loading/unloading to hide visual side effects . |
@thomasf You are right, the sentence |
Solarized is one of the only themes that seems to have side effects that somehow result from an update/install. I haven't had time to investigate why this is, but this should probably be avoided.
The text was updated successfully, but these errors were encountered: