Ui tweaks #36
Merged
Ui tweaks #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
June 24, 2019 18:53
fixed by adding this.projectsUrl inside constructor of APIWrapper class
added ADL, EDL, FCPX export + rearranged btns layour in programme script
of programme script with sortable lib
added a sortable lib to programme script elements and initial icon for delete without functionality
delete programme script elements
json as developer option for troubleshooting, for programme script
voice over, notes, heading/title
voice over, notes, titles, but not paper-cuts
voice over, notes, titles
added some unit tests for it, updated video context to patch audio glitch
tweaked layout proportion for transcript - programme script view on/off added timecode info in speaker on hover, and removed from transcript, can now click on speaker to jump to corresponding point in media, in transcript
project/transcripts only links to correct view that uses @bbc/react-transcript-edito r, to go to annotations need to go through programme script. kept the /annotate end point and view, as it's useful for troubleshooting and development for now
fixed edit/create label in transcript/programme script view. Somehow if using Dropdown.Item, the modal to edit the labI wouldn't allow spacing in the form text input. But it works when using ListGroup.Item. Minor UI tweaks still needed for the labels dorpdown - but functionality wise it's working
to get rid of warnings
changed highlights/annotations to be on word level rather then paragraph level in transcript/programme script, this means you can select text and create highlights/annotations across paragraphs in a transcript. Preserves functionality where paragraphs can be filtered in search bar based on highlights
|
|
added 3 commits
July 12, 2019 18:08
link is done by LinkContainer component, and a href is just hornamental, but fixed the id passed into the href so that it's shown on hover on the client side, for consitency
server returns 204 so uses response.ok to check if response is sucesfull on the client side
plus other tweaks
added 24 commits
July 13, 2019 23:01
added word highlights on play in Transcript in Programme script / paperedit view, with the right specificity to work across different transcripts
for clarity
added transcript word highlight to annotated view as well to avoid two components to drift out of sync too much, even tho for now we ar not using the annotated view as part of the current user journey
found better way to swap out db wrappe in browser and electron env. has corresponding changes in electron repo
has corresponding changes in electron repo
refactored electron wrapper integration, only called when client run inside of electron, and adds electron wrapper in render process rather then previous setup where it was added to the main process. adding to electron main process, something that is computational intensive, resulted in the app to hang. tested current setup and works fine, left comment in code for ease of picking up later
module overlap in @bbc/react-transcript-editor repo so made PR there bbc/react-transcript-editor#166 as well
still quiet a few to go
* final fix + clean up unecessary comments * Removed dbWrapper in DemoApiWrapper as not in use * Removed index demo logic as demo env is detected in ApiWrapper class * Removed unecessary console.log * moved demo check in whichJsEnv module * added prepublish step to prep build folder, and remove the db folder with json for client publishing
to bootstrap-css-only
fixed saving and updating annotations, added timer for checking for incomplete transcripts
* fixed and removed timer * refactored timer to check for in progress transcripts
kept copy in #43 backup draft PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
It's connected with the upcoming user testing, and exploring the minimum that needs to be done on this build to have users try out the front end with their own content
Describe what the PR does
xmlreact-sortable-hoc- basic example usage)State whether the PR is ready for review or whether it needs extra work
Work in progress
Additional context
Still outstanding