adjusted DPE adapter #166
Closed
adjusted DPE adapter #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2019 13:08
so that it preserves paragraphs break within contiguos speakers
pietrop
force-pushed
the
murezzda-update-timestamps-diff-dpe-groups-words-by-speaker
branch
from
5251b41
to
f25c064
Compare
|
leaving a note that fixed one of the tests (word count comparison) but couldn't figure out why the other test on |
pietrop
pushed a commit
to bbc/digital-paper-edit-client
that referenced
this pull request
Jul 16, 2019
module overlap in @bbc/react-transcript-editor repo so made PR there bbc/react-transcript-editor#166 as well
left aligning as a step before save btn and before export function, rather then as a step that happens everytime autosave is triggered, as that might be unecessary, and add performance overhead, I also noticed the cursor position jumped after realignement, thought something was been put in place to preserve/avoid that?
Co-Authored-By: Pietro <pietro.passarelli@gmail.com>
Co-Authored-By: Pietro <pietro.passarelli@gmail.com>
Co-Authored-By: Pietro <pietro.passarelli@gmail.com>
Adding speech to text adapter for Google cloud platform
pietrop
pushed a commit
to bbc/digital-paper-edit-client
that referenced
this pull request
Jul 26, 2019
* fix: client was not receiving data from server in local dev fixed by adding this.projectsUrl inside constructor of APIWrapper class * improved programme script btn options * Refactor programme script btns added ADL, EDL, FCPX export + rearranged btns layour in programme script * adjusted size of play/stop btn for videoContext preview component * Added reorder of programme script with sortable lib * added sortable to programme script elements added a sortable lib to programme script elements and initial icon for delete without functionality * added possibility to delete delete programme script elements * adding try catch around get projects * adding credentials include in fetch request options * credentials omit * Remove omit * added export for txt and json json as developer option for troubleshooting, for programme script * tweaked hide /show transcript/programme script btns * Added support for programme script elements voice over, notes, heading/title * added possibility to edit programme script elements voice over, notes, titles, but not paper-cuts * can now add items at a specific insert point * can use insert point for other programme script elements voice over, notes, titles * can now select mutiple paragraphs to add to programme script added some unit tests for it, updated video context to patch audio glitch * adjusted layout + ui tweaked layout proportion for transcript - programme script view on/off added timecode info in speaker on hover, and removed from transcript, can now click on speaker to jump to corresponding point in media, in transcript * added annotations to transcript/programme script view * changed transcript to correct only project/transcripts only links to correct view that uses @bbc/react-transcript-edito r, to go to annotations need to go through programme script. kept the /annotate end point and view, as it's useful for troubleshooting and development for now * fix edit/create labels fixed edit/create label in transcript/programme script view. Somehow if using Dropdown.Item, the modal to edit the labI wouldn't allow spacing in the form text input. But it works when using ListGroup.Item. Minor UI tweaks still needed for the labels dorpdown - but functionality wise it's working * refactored programmeScriptJsonToText to get rid of warnings * removed warnings * changed highlight to be on word level changed highlights/annotations to be on word level rather then paragraph level in transcript/programme script, this means you can select text and create highlights/annotations across paragraphs in a transcript. Preserves functionality where paragraphs can be filtered in search bar based on highlights * quick fix in project list link link is done by LinkContainer component, and a href is just hornamental, but fixed the id passed into the href so that it's shown on hover on the client side, for consitency * fixed projects delete response server returns 204 so uses response.ok to check if response is sucesfull on the client side * Added programme script save plus other tweaks * if not programme script in list don't show search option * ApiWrapper electron refactor initial refactor to change Api/db wrapper depending on env, whether in browser or electron - not finished, tested that it can detect electron env even in development served from server * Added index to papercuts * added word highlights added word highlights on play in Transcript in Programme script / paperedit view, with the right specificity to work across different transcripts * renamed search text for clarity * added word highlight to annotated view added transcript word highlight to annotated view as well to avoid two components to drift out of sync too much, even tho for now we ar not using the annotated view as part of the current user journey * switch ApiWrapper for ElectronWrapper if in electron ENV found better way to swap out db wrappe in browser and electron env. has corresponding changes in electron repo * removed uncessary console.log * added logic to switch between API wrapper and electron wrapper * fixed typo * added logic to import file in electron when creating new transcript has corresponding changes in electron repo * Refactor electron wrapper integration refactored electron wrapper integration, only called when client run inside of electron, and adds electron wrapper in render process rather then previous setup where it was added to the main process. adding to electron main process, something that is computational intensive, resulted in the app to hang. tested current setup and works fine, left comment in code for ease of picking up later * removed unecessary console.log + fixed typos * upgraded adl module * fixed preserving paragraphs when grouping words by speakers module overlap in @bbc/react-transcript-editor repo so made PR there bbc/react-transcript-editor#166 as well * Removed some uncessary console.log still quiet a few to go * Demo app for github pages (#40) * final fix + clean up unecessary comments * Removed dbWrapper in DemoApiWrapper as not in use * Removed index demo logic as demo env is detected in ApiWrapper class * Removed unecessary console.log * moved demo check in whichJsEnv module * added prepublish step to prep build folder, and remove the db folder with json for client publishing * updated demo alert message * modified demo message * replaced bootstrap to bootstrap-css-only * adding metadata info in programme script * adding metadata info in programme script * fixed annotations and added timer to transcripts list fixed saving and updating annotations, added timer for checking for incomplete transcripts * Added default var for ADL/EDL values * Transcript progress timer (#42) * fixed and removed timer * refactored timer to check for in progress transcripts * removed transcript annotation standalone view kept copy in #43 backup draft PR * added react components repo link to README
added 4 commits
July 31, 2019 16:42
* moved header into a component with shouldComponentUopdate false to avoid unecessary re-renders - test * moved Header component into separate file +removed unused styling, commented out for now in case it's needed, eg in mobile view? * moved playback_rates const into separate file * optimised re-render of playback rate * optimise re-render for VideoPlayer * added some notes - draft on how to prevent uncessary re-renders in React * Added some comments * small note in docs about using console.log in render to measure performance * ammend to notes * Update 2019-05-16-prevent-unnecessary-re-renders-in-react.md * notes update * notes fix * trying out why-did-you-update * updated MediaPlayer and subcomponents * made ToolTip 'how does this work' into it's own component * updated Demo app to reduce unecessary re-renders * added react-visibility-sensor * refactor settings * removed unecessary attributes from state of components + WrapperBlock performance tweak using react-visibility-sensor
* Added timestamp update via diff tool * Added missing function * Commited intermediate state * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process. * Update Timestamps now works correctly. * Fixed errors from rebase, removed debug code * Moved UpdateTimestamp into its own folder. * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code * Added documentation * Merged timer for updating the timestamps and local save. * Selection state is now kept across updates to timestamps * Fixed bug where words with punctuation always are considered as new words. Timestamp update function now also uses the alignWords function directly instead of alignJSONText, removing some overhead. * Fixed small bug which raised an error if an empty block was present during timestamp update * Changed time of timestamp-update. Now re-calculates the timestamps after 5 seconds if the transcript has been edited or if the user saves the transcript manually with the save button * Code cleanup
* Added timestamp update via diff tool * Added missing function * Commited intermediate state * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process. * Update Timestamps now works correctly. * Fixed errors from rebase, removed debug code * Moved UpdateTimestamp into its own folder. * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code * Added timestamp update via diff tool * Added missing function * Commited intermediate state * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process. * Update Timestamps now works correctly. * Fixed errors from rebase, removed debug code * Moved UpdateTimestamp into its own folder. * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code * Added documentation * Merged timer for updating the timestamps and local save. * Selection state is now kept across updates to timestamps * Fixed bug where words with punctuation always are considered as new words. Timestamp update function now also uses the alignWords function directly instead of alignJSONText, removing some overhead. * Fixed small bug which raised an error if an empty block was present during timestamp update * Changed time of timestamp-update. Now re-calculates the timestamps after 5 seconds if the transcript has been edited or if the user saves the transcript manually with the save button * Code cleanup * some changes to show sudgestions for PR * added some of changes sudgested in PR * Update package.json
…s-words-by-speaker
Merged
|
addressed in #175 |
jamesdools
deleted the
murezzda-update-timestamps-diff-dpe-groups-words-by-speaker
branch
jamesdools
restored the
murezzda-update-timestamps-diff-dpe-groups-words-by-speaker
branch
jamesdools
deleted the
murezzda-update-timestamps-diff-dpe-groups-words-by-speaker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
NA
Describe what the PR does
preserves paragraphs break within contiguos speakers for DPE adapter
State whether the PR is ready for review or whether it needs extra work
Almost ready for review, need to update the tests
Additional context
NA