Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cython acceleration for websockets #36

Merged
merged 2 commits into from
May 21, 2018
Merged

Use cython acceleration for websockets #36

merged 2 commits into from
May 21, 2018

Conversation

j616
Copy link
Contributor

@j616 j616 commented May 21, 2018

As per performance section at https://bitbucket.org/noppo/gevent-websocket

@j616 j616 requested a review from andrewbonney May 21, 2018 14:41
@andrewbonney
Copy link
Contributor

Were the overrides necessary in this case? In general if the only difference in naming between the pip and Debian versions is the addition of 'python-' and 'python3-' they shouldn't be required, unless you're hitting a case of #15

@j616
Copy link
Contributor Author

j616 commented May 21, 2018

I guess not. I thought that might be the case but I saw gevent python3-gevent at the top of the list for python3 and assumed we were going for explicit rather than implicit.

@andrewbonney andrewbonney mentioned this pull request May 21, 2018
Closed
@j616 j616 merged commit 2755107 into master May 21, 2018
@j616 j616 deleted the jamessa-geventWSPerformance branch May 21, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbonney andrewbonney andrewbonney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j616 @andrewbonney