Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function raise an exception when no services found or end of list reached #26

Merged
merged 18 commits into from
Oct 14, 2019
Merged

Add function raise an exception when no services found or end of list reached #26

merged 18 commits into from
Oct 14, 2019

Conversation

JamesGibo
Copy link
Contributor

So support for exponential backoff can be added to the Node API, when registry's return 5xx

andrewbonney
andrewbonney reviewed Jul 22, 2019
View reviewed changes
mdnsbridge/mdnsbridgeclient.py Outdated Show resolved Hide resolved
mdnsbridge/mdnsbridgeclient.py Outdated Show resolved Hide resolved
@JamesGibo
Copy link
Contributor Author

PR finished, will squash and merge.
Separate PR will be raised for concatenating Registration DNS-SD service type results

andrewbonney
andrewbonney reviewed Oct 10, 2019
View reviewed changes
Copy link
Contributor

@andrewbonney andrewbonney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually looks like it will do the job. Just a few minor notes to look at. Once they're sorted I'll give it a test locally to ensure the existing behaviour remains the same.

mdnsbridge/mdnsbridgeclient.py Outdated Show resolved Hide resolved
mdnsbridge/mdnsbridgeclient.py Outdated Show resolved Hide resolved
mdnsbridge/mdnsbridgeclient.py Show resolved Hide resolved
mdnsbridge/mdnsbridgeclient.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@JamesGibo JamesGibo changed the title Add function to list valid services Add function raise an exception when no services found or end of list reached Oct 10, 2019
@JamesGibo JamesGibo merged commit 9e44661 into master Oct 14, 2019
@JamesGibo JamesGibo deleted the jamesg-backoff branch October 14, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbonney andrewbonney andrewbonney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JamesGibo @andrewbonney