This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
fix a11y Talkback reading nested spans incorrectly in in psammead-brand #4586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenc05
reviewed
Nov 3, 2021
DarioR01
changed the title
7 tasks
pvaliani
reviewed
Nov 15, 2021
| serviceLocalisedName ? ( | ||
| // id={`BrandLink-${linkId}` is a temporary fix for the a11y nested span's bug experienced in TalkBack, refer to the following issue: https://github.com/bbc/simorgh/issues/9652 |
There was a problem hiding this comment.
I had a look at the issue. Can I ask why this is a temporary fix? Is it only temporary until Google/TalkBack provide a fix or is it a temporary fix for us over a fixed period? Thanks
There was a problem hiding this comment.
until Google/Talkback fixes it. But we think they are going to take a very long time. I will specify this in the issue link.
There was a problem hiding this comment.
Well it could take a long time for Google to fix, this bug has been present for some time, though we hope they might fix it soon, it's out of our control and really affecting the user experience of our product, so we have a temporary fix until such time that Google fix it.
jroebu14
approved these changes
Nov 15, 2021
ryanmccombe
approved these changes
Nov 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9561
Overall change:
fix a11y Talkback reading nested spans incorrectly in psammead-brand
Code changes:
-concatenate span content