Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Grid example to Storybook #3679

Closed
1 task done
EinsteinNjoroge opened this issue Sep 10, 2019 · 0 comments · Fixed by #3693
Closed
1 task done

Add Grid example to Storybook #3679

EinsteinNjoroge opened this issue Sep 10, 2019 · 0 comments · Fixed by #3693
Assignees
@EinsteinNjoroge
Labels
shared-components
Projects
Simorgh

Comments

@EinsteinNjoroge
Copy link
Contributor

EinsteinNjoroge commented Sep 10, 2019 •
edited by PriyaKR

Is your feature request related to a problem? Please describe.
Currently, we don't display the grid layout with FrontPageMain and ArticleMain pages in Storybook.

Describe the solution you'd like
Add example to Storybook for FrontPageMain and ArticleMain. (Needs the example with Headline, Paragraph, timestamp, Portrait Image with Caption, Landscape Image with Caption, Square Image with Caption.)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
Examples of front page and article page should be available in simorgh storybook.

Dev insight: This should be to just add the Storybook stories - no impact on the components or the application - so it shouldn't need tests. Just a manual check of Storybook.

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.
@EinsteinNjoroge EinsteinNjoroge added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. shared-components labels Sep 10, 2019
@EinsteinNjoroge EinsteinNjoroge added this to To do in Simorgh via automation Sep 10, 2019
@EinsteinNjoroge EinsteinNjoroge changed the title Add Grid test cases to Storybook Add Grid example to Storybook Sep 10, 2019
@sareh sareh added the grid label Sep 10, 2019
@EinsteinNjoroge EinsteinNjoroge self-assigned this Sep 10, 2019
@EinsteinNjoroge EinsteinNjoroge moved this from To do to Issue in Progress in Simorgh Sep 10, 2019
@sareh sareh mentioned this issue Sep 10, 2019
Closed
1 task
@EinsteinNjoroge EinsteinNjoroge mentioned this issue Sep 10, 2019
Merged
3 tasks
@PriyaKR PriyaKR removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Sep 11, 2019
Simorgh automation moved this from Issue in Progress to Done Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EinsteinNjoroge EinsteinNjoroge

Labels
shared-components
Projects
No open projects
Simorgh
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Grid example to Storybook bbc/simorgh
3 participants
@sareh @PriyaKR @EinsteinNjoroge