-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Grid example to Storybook #3693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Storybook stories for FrontPageMain and ArticleMain to display grid layout and catch future changes in chromatic.
I might be missing something, Is this not covered by the full page snapshots we have? As were trying to slim down the number of stories we run on chromaticqa (money), im not sure of the overlap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @EinsteinCarrey. I've suggested some changes here.
@dr3 currently, we don't have visual tests for the grid layout. The idea here is to display the entire |
@EinsteinCarrey Is the FrontPageMain not shown in https://bbc.github.io/simorgh/?path=/story/pages-front-page--igbo as part of the page? |
@dr3 The |
Co-Authored-By: Sareh <sareh@users.noreply.github.com>
Co-Authored-By: Sareh <sareh@users.noreply.github.com>
Co-Authored-By: Sareh <sareh@users.noreply.github.com>
Co-Authored-By: Sareh <sareh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks great. Thanks for the updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
Resolves #3679
Overall change: Add Storybook stories for
FrontPageMain
andArticleMain
to display grid layout and catch future changes in chromatic.Code changes:
ArticleMain
to display an article main with Headline, Paragraph, timestamp, Portrait Image with Caption, Landscape Image with Caption and a square Image with Caption._Screenshots:
FrontPagesMain
ArticleMain