Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new Grid for all Pages (Parent) #3686

Closed
1 task done
sareh opened this issue Sep 10, 2019 · 5 comments
Closed
1 task done

Use new Grid for all Pages (Parent) #3686

sareh opened this issue Sep 10, 2019 · 5 comments
Labels
cross-team For visibility for both World Service teams (Engage & Media) investigation Parent Issue Parent issue for new features/components which links to all relating issues technical-work Technical debt, support work and building new technical tools and features
Milestone
Simorgh 3.0

Comments

@sareh
Copy link
Contributor

sareh commented Sep 10, 2019 •
edited by DenisHdz

Is your feature request related to a problem? Please describe.
Our aim is to simplify the grid for Simorgh and to make it flexible to be used not just at the page level, but at the component level as well. This is the fourth of several issues - all labelled here

Describe the solution you'd like
After completing issues: #3679 #3684 #3685, we should have a Grid component with support for browsers that do and don't support CSS Grid.

  • We should use new Grid for ArticleMain, ErrorMain, MediaPageMain containers
  • Accessibility swarm on this ticket, since it integrates the new Grid into our pagetypes, some of which are currently live.

Describe alternatives you've considered
N/A

Testing notes
ArticleMain, ErrorMain, MediaPageMain containers in simorgh storybook should be verified across different breakpoints and also the pagetypes(front page ,error page and article page) requires cross browser and device testing.The browsers which doesn't support css grid(IE11,10, ios s10 safari and opera mini) should have the css grid fallback implemented.

Dev insight: A full accessibility review of the changes. The visual regressions should be captured by the Chromatic QA storybook tests for these four ArticleMain, ErrorMain, MediaPageMain containers.

  • This feature is expected to need manual testing.

Additional context
Initial issue with Proof of Concept example: #2313
@sareh sareh added blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. shared-components grid labels Sep 10, 2019
@sareh sareh added this to To do in Simorgh via automation Sep 10, 2019
@PriyaKR PriyaKR removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Sep 11, 2019
@sareh sareh moved this from To do to Ready for dev in Simorgh Sep 13, 2019
@sareh sareh self-assigned this Oct 31, 2019
@sareh sareh removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Oct 31, 2019
@sareh sareh moved this from Ready for dev to Issue in Progress in Simorgh Oct 31, 2019
@DenisHdz DenisHdz moved this from Issue in Progress to Ready for dev in Simorgh Oct 31, 2019
@sareh sareh mentioned this issue Oct 31, 2019
Closed
4 tasks
@DenisHdz DenisHdz moved this from Ready for dev to Issue in Progress in Simorgh Nov 1, 2019
This was referenced Nov 5, 2019
Merged
Merged
@sareh sareh mentioned this issue Jan 8, 2020
Merged
6 tasks
@sareh sareh moved this from Issue in Progress to Blocked (by something outside pod) in Simorgh Jan 24, 2020
@sareh
Copy link
Contributor Author

sareh commented Jan 24, 2020

The work has been carried out for Error pages and Live Radio pages. The CPS page types are being refactored at the moment - so it's better to wait until that work is complete before carrying out these, to minimise conflicts.

@sareh sareh added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jan 24, 2020
@DenisHdz DenisHdz added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. and removed blocked This issue should not be worked on until another internal issue is completed - see desc for details labels Mar 4, 2020
@DenisHdz DenisHdz moved this from Blocked (by something outside pod) to To do in Simorgh Mar 4, 2020
@DenisHdz DenisHdz changed the title Use new Grid for ArticleMain, FrontPageMain, ErrorMain, MediaPageMain Use new Grid for ArticleMain, ErrorMain, MediaPageMain Mar 4, 2020
@sareh sareh changed the title Use new Grid for ArticleMain, ErrorMain, MediaPageMain Use new Grid for all Pages Mar 5, 2020
@sareh sareh mentioned this issue May 19, 2020
Closed
1 task
@ghost
Copy link

ghost commented May 20, 2020

Had any further work been done on this? Am happy to make the changes to the STY page to use the new Grid.

This was referenced May 20, 2020
Merged
Closed
@ghost
Copy link

ghost commented Jun 8, 2020

@sareh What should be the grid columns for CPS pages? is it

group1: 6,
group2: 6,
group3: 6,
group4: 8,
group5: 8,

@amywalkerdev amywalkerdev moved this from Issue in Progress to Ready for dev in Simorgh Jun 21, 2020
@amywalkerdev amywalkerdev added ws-media World Service Media ws-articles Tasks for the WS Articles Team and removed ws-home labels Jun 30, 2020
@joshcoventry joshcoventry moved this from Backlog (Ready for dev) to Coming soon in Simorgh Jul 1, 2020
@joshcoventry joshcoventry removed the grid label Jul 10, 2020
@karinathomasbbc karinathomasbbc added cross-team For visibility for both World Service teams (Engage & Media) and removed ws-articles Tasks for the WS Articles Team ws-media World Service Media labels Jul 20, 2020
@FK78 FK78 self-assigned this Jul 22, 2020
@FK78 FK78 moved this from Coming Soon to Issue in Progress in Simorgh Jul 22, 2020
@FK78
Copy link
Contributor

FK78 commented Jul 22, 2020 •
edited

Pages not using Grid:

  • ArticlePage
  • ErrorPage
  • LiveRadioPage
  • MediaAssetPage
  • MostReadPage
  • OnDemandRadioPage
  • OnDemandTvPage
  • PhotoGalleryPage
  • StoryPage

Pages using Grid:

  • FrontPage
  • IdxPage

@joshcoventry joshcoventry added investigation technical-work Technical debt, support work and building new technical tools and features and removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Jul 22, 2020
@FK78 FK78 mentioned this issue Aug 3, 2020
Closed
6 tasks
@HarveyPeachey HarveyPeachey self-assigned this Aug 10, 2020
@HarveyPeachey HarveyPeachey added the Parent Issue Parent issue for new features/components which links to all relating issues label Aug 17, 2020
This was referenced Aug 17, 2020
Closed
Closed
Closed
@joshcoventry joshcoventry changed the title Use new Grid for all Pages Use new Grid for all Pages (Parent) Aug 25, 2020
@joshcoventry joshcoventry moved this from Issue in Progress to Backlog (Ready for dev) in Simorgh Aug 25, 2020
@joshcoventry joshcoventry added this to the Simorgh 3.0 milestone Sep 3, 2020
@joshcoventry joshcoventry removed this from Backlog (Ready for dev) in Simorgh Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cross-team For visibility for both World Service teams (Engage & Media) investigation Parent Issue Parent issue for new features/components which links to all relating issues technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Milestone
Simorgh 3.0
Development

Successfully merging a pull request may close this issue.

Use @bbc/psammead-grid bbc/simorgh
9 participants
@sareh @HarveyPeachey @PriyaKR @j-pendlebury @FK78 @amywalkerdev @DenisHdz @karinathomasbbc @joshcoventry