Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @bbc/psammead-grid in the Paragraph container #7397

Closed
wants to merge 6 commits into from
Closed

Use @bbc/psammead-grid in the Paragraph container #7397

wants to merge 6 commits into from

Conversation

FK78
Copy link
Contributor

@FK78 FK78 commented Aug 3, 2020 •
edited

Part of #3686

Overall change:
A very high-level summary of easily-reproducible changes that can be understood by non-devs.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
  • I have assigned myself to this PR and the corresponding issues
  • I have added the cross-team label to this PR if it requires visibility across World Service teams
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing

@FK78 FK78 self-assigned this Aug 3, 2020
@FK78 FK78 added the cross-team For visibility for both World Service teams (Engage & Media) label Aug 3, 2020
@FK78 FK78 added this to PR in Progress in Simorgh via automation Aug 3, 2020
@joshcoventry joshcoventry added this to the Simorgh 3.0 milestone Sep 3, 2020
@joshcoventry joshcoventry removed this from PR in Progress in Simorgh Sep 3, 2020
@joshcoventry joshcoventry deleted the grid-paragraph branch November 18, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FK78 FK78

Labels
cross-team For visibility for both World Service teams (Engage & Media)
Projects
None yet
Milestone
Simorgh 3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FK78 @joshcoventry