Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Line From Recommendation Label On Mobile Breakpoints #10116

Merged
merged 2 commits into from
May 18, 2022
Merged

Remove Line From Recommendation Label On Mobile Breakpoints #10116

merged 2 commits into from
May 18, 2022

Conversation

DarioR01
Copy link
Contributor

@DarioR01 DarioR01 commented May 17, 2022 •
edited
Loading

Resolves WSTEAM1-68

Overall change:
Remove Line From Recommendation Label On Mobile Breakpoints

Code changes:

  • passed mobileDivider attribute as false to the SectionLabel.
  • I have assigned myself to this PR and the corresponding issues
  • I have added the cross-team label to this PR if it requires visibility across World Service teams
  • I have assigned this PR to the Simorgh project
  • (BBC contributors only) This PR follows the repository use guidelines

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)
  • This PR requires manual testing

@DarioR01 DarioR01 self-assigned this May 17, 2022
@DarioR01 DarioR01 added Recommendations Work for the WS Recommendations onward journey ux To be reviewed by UX before merging labels May 17, 2022
@DarioR01 DarioR01 marked this pull request as ready for review May 17, 2022 15:03
MuhammadAHussain
MuhammadAHussain approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@MuhammadAHussain MuhammadAHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amoore108 amoore108 merged commit 6cd98bf into latest May 18, 2022
@amoore108 amoore108 deleted the WSTEAM1-68-mobile-recommendation-line branch May 18, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoore108 amoore108 amoore108 approved these changes

@MuhammadAHussain MuhammadAHussain MuhammadAHussain approved these changes

Assignees

@DarioR01 DarioR01

Labels
Recommendations Work for the WS Recommendations onward journey ux To be reviewed by UX before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarioR01 @amoore108 @MuhammadAHussain