Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-547: Update to Node 18 #11015

Merged
merged 93 commits into from
Aug 24, 2023
Merged

WSTEAM1-547: Update to Node 18 #11015

merged 93 commits into from
Aug 24, 2023

Conversation

shayneahchoon
Copy link
Contributor

@shayneahchoon shayneahchoon commented Aug 17, 2023

Resolves JIRA WSTEAM1-547

Code changes

Changes the following actions to use node 18.x runtime environment:

  • .github/workflows/simorgh-e2e-tests.yml
  • .github/workflows/simorgh-integration-tests.yml
  • .github/workflows/simorgh-local-server-tests.yml
  • .github/workflows/simorgh-misc-checks.yml
  • .github/workflows/simorgh-release-asset.yml
  • .github/workflows/simorgh-unit-tests.yml
  • .nvmrc

Compatibility changes:

Also VERY IMPORTANT:

  • ramda has been updated to package version 0.29 and part of this change means that the prop order for pathEq/propEq have now changed inline with Ramda docs: Ramda 0.29

Coding Standards

Repository use guidelines

@amoore108 amoore108 changed the title WSTEAM1-547: Change node version WSTEAM1-547: Update to Node 18 Aug 21, 2023
@amoore108 amoore108 marked this pull request as ready for review August 21, 2023 14:34
@amoore108 amoore108 changed the title WSTEAM1-547: Update to Node 18 [DNM] WSTEAM1-547: Update to Node 18 Aug 21, 2023
Copy link
Contributor

@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@HarveyPeachey HarveyPeachey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did something weird happen here with the commits? There's 88 of them and some back date to May

@amoore108
Copy link
Contributor

Did something weird happen here with the commits? There's 88 of them and some back date to May

Yea we accidentally pulled in changes from my NextJS 13.x upgrade branch, but it has been reverted. The commit history will look weird here but should be squashed when merged.

@amoore108 amoore108 changed the title [DNM] WSTEAM1-547: Update to Node 18 WSTEAM1-547: Update to Node 18 Aug 24, 2023
@amoore108 amoore108 merged commit 841d8dc into latest Aug 24, 2023
11 checks passed
@amoore108 amoore108 deleted the WSTEAM1-547-GIT-NODE-18 branch August 24, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants