-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAM1-547: Update to Node 18 #11015
Conversation
…in latest Next.JS
- Newer versions of Lighthouse drop the 'bestPractices' score significantly if these now deprecated APIs are set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did something weird happen here with the commits? There's 88 of them and some back date to May
Yea we accidentally pulled in changes from my NextJS 13.x upgrade branch, but it has been reverted. The commit history will look weird here but should be squashed when merged. |
86d170c
to
fd390fb
Compare
This reverts commit 0940c88.
fd390fb
to
4357f7f
Compare
Resolves JIRA WSTEAM1-547
Code changes
Changes the following actions to use node 18.x runtime environment:
.github/workflows/simorgh-e2e-tests.yml
.github/workflows/simorgh-integration-tests.yml
.github/workflows/simorgh-local-server-tests.yml
.github/workflows/simorgh-misc-checks.yml
.github/workflows/simorgh-release-asset.yml
.github/workflows/simorgh-unit-tests.yml
.nvmrc
Compatibility changes:
--no-experimental-fetch
, as Node 18 introduces a new fetch mechanism under the hood: https://nodejs.org/en/blog/announcements/v18-release-announce#fetch-experimental. We will likely need to tackle this when we update Next.JS to version 13.x, as it forces usage of the new fetch mechanismExpect-CT
header: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Expect-CTprefetch-src
header: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/prefetch-srcbestPractices
Lighthouse metric, so they have been removed as they are no longer supportedAlso VERY IMPORTANT:
ramda
has been updated to package version0.29
and part of this change means that the prop order forpathEq/propEq
have now changed inline with Ramda docs: Ramda 0.29Coding Standards
Repository use guidelines