-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAM1-1005: Gujarati Telugu font updates #11599
WSTEAM1-1005: Gujarati Telugu font updates #11599
Conversation
const MALLANA_FONTS_DIR = | ||
'https://ws-downloads.files.bbci.co.uk/fonts/Mallanna/v1.0.4/'; | ||
const NOTO_SANS_TELUGU_FONTS_DIR = | ||
'https://ws-downloads.files.bbci.co.uk/fonts/NotoSansTelugu/v1.00/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not live yet, hence 'do not merge' label
'https://ws-downloads.files.bbci.co.uk/fonts/NotoSansTelugu/v1.00/'; | ||
|
||
const NOTO_SANS_GUJARATI_FONTS_DIR = | ||
'https://ws-downloads.files.bbci.co.uk/fonts/NotoSansGujarati/v1.00/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not live yet, hence 'do not merge' label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a PR for the font server repo or is that already up there/has it been merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep it's linked in this ticket: https://jira.dev.bbc.co.uk/browse/WSTEAM1-1003
It has been merged but I'm still working through the steps to deploy
Re-running the E2E's on this but Cypress just got patched this morning: And i'm not sure if the failure is related, just FYI. |
Resolves JIRA WSTEAM1-1005 - Simorgh Changes, subtask of WSTEAM1-900 - Updated fonts for two Indian services
Overall changes
Updates default fonts for two services
Telugu from 'Mallanna' to 'Noto Sans Telugu'
Gujarati from 'Mukta Vaani' to 'Noto Sans Gujarati'
Code changes
STORYBOOK
THEME PROVIDER
PSAMMEAD
Testing
I think UX can test this on preview. Otherwise we can put a change freeze in and test on test.
Helpful Links
Dropbox paper instructions
Coding Standards
Repository use guidelines