Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-972 - Uploader error screen #11727

Merged
merged 18 commits into from
Jun 24, 2024
Merged

Conversation

amoore108
Copy link
Contributor

@amoore108 amoore108 commented Jun 14, 2024

Resolves JIRA https://jira.dev.bbc.co.uk/browse/WSTEAM1-972

Overall changes

  • Adds ErrorScreen component
  • Sets page title to Error: {title} if the user lands on this screen
  • Adds Storybook story for error screen
  • Renames existing Form to FormScreen for naming consistency
  • Renames existing SuccessMessage to SuccessScreen for naming consistency
  • Unrelated fix to return correct page type for Webvitals as this was throwing console errors

Testing

  1. Visit https://wsteam1-972-uploader-error-screen--5d28eb3fe163f6002046d6fa.chromatic.com/iframe.html?args=&id=pages-ugc-page--error-screen&viewMode=story
  2. Confirm it renders correctly and aligns to a11y AAC / screen-reader guidelines
  3. Check the page title starts with Error: (translations to follow)

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@amoore108 amoore108 self-assigned this Jun 14, 2024
@amoore108 amoore108 marked this pull request as ready for review June 19, 2024 08:53
@@ -1,3 +1,4 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second time I've seen this sneaky new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea seems to get generated from running yarn storybook 👽

@amoore108 amoore108 merged commit 2cfaad1 into latest Jun 24, 2024
11 checks passed
@amoore108 amoore108 deleted the WSTEAM1-972-uploader-error-screen branch June 24, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants