Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1083: Update validation function #11728

Merged

Conversation

shayneahchoon
Copy link
Contributor

@shayneahchoon shayneahchoon commented Jun 14, 2024

Resolves JIRA WSTEAM-1083

Overall changes

Updates the validation functions to cover all expected use cases.

Code changes

  • ws-nextjs-app/pages/[service]/send/[id]/FormContext/utils/validateFunctions.ts updated to incorporate file validation logic.
  • ws-nextjs-app/pages/[service]/send/[id]/FormContext/index.tsx updated to propagate the validation data from the UGC api, so that this can be used by the validation functions.
  • Message codes added to match their respective morph translations.

Testing

  1. List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@shayneahchoon shayneahchoon marked this pull request as draft June 14, 2024 14:53
@shayneahchoon shayneahchoon marked this pull request as ready for review June 18, 2024 09:47
@shayneahchoon shayneahchoon merged commit 0a4a94f into WSTEAM1-1018-input-fields-error-ux Jun 18, 2024
9 checks passed
@shayneahchoon shayneahchoon deleted the WSTEAM1-1083-VALDATION branch June 18, 2024 14:44
@shayneahchoon
Copy link
Contributor Author

shayneahchoon commented Jun 18, 2024

Have merged into this one: WSTEAM1-1018-input-fields-error-ux, to reduce merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants