-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAM1-1018 Implement Error Handling UX for Input fields - Validation #11726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isabella-Mitchell
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for making those changes :)
* WSTEAM1-1083: Update validation function * WSTEAM1-1083: restructure * WSTEAM1-1083: add validations * validate file isnt broken * file total too big * UX * WSTEAM1-1083: Update * WSTEAM1-1083: Update merge --------- Co-authored-by: emilysaffron <emily.saffron@bbc.co.uk>
amoore108
reviewed
Jun 19, 2024
amoore108
reviewed
Jun 19, 2024
ws-nextjs-app/pages/[service]/send/[id]/FormContext/utils/validateFunctions.ts
Show resolved
Hide resolved
amoore108
reviewed
Jun 19, 2024
.yarn/cache/eslint-plugin-json-npm-3.1.0-2165d5ec5d-0a4d1efb79.zip
Outdated
Show resolved
Hide resolved
ws-nextjs-app/pages/[service]/send/[id]/FormContext/utils/validateFunctions.ts
Outdated
Show resolved
Hide resolved
shayneahchoon
force-pushed
the
WSTEAM1-1018-input-fields-error-ux
branch
from
June 20, 2024 10:48
6169df0
to
0e05de5
Compare
HarveyPeachey
approved these changes
Jun 20, 2024
…imorgh into WSTEAM1-1018-input-fields-error-ux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA WSTEAM1-1018
Overall changes
Implements the error labels for form input fields not including the file uploader or the summary box.
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines