Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1018 Implement Error Handling UX for Input fields - Validation #11726

Merged
merged 33 commits into from
Jun 27, 2024

Conversation

emilysaffron
Copy link
Contributor

@emilysaffron emilysaffron commented Jun 14, 2024

Resolves JIRA WSTEAM1-1018

Overall changes

Implements the error labels for form input fields not including the file uploader or the summary box.

Code changes

Testing

  1. Visit http://localhost.bbc.com:7081/mundo/send/u50853489?renderer_env=live or the storybook link , submit an invalid form and observe the error handling. Check it matches the UX designs

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@emilysaffron emilysaffron marked this pull request as ready for review June 14, 2024 13:12
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for making those changes :)

* WSTEAM1-1083: Update validation function

* WSTEAM1-1083: restructure

* WSTEAM1-1083: add validations

* validate file isnt broken

* file total too big

* UX

* WSTEAM1-1083: Update

* WSTEAM1-1083: Update merge

---------

Co-authored-by: emilysaffron <emily.saffron@bbc.co.uk>
@shayneahchoon shayneahchoon force-pushed the WSTEAM1-1018-input-fields-error-ux branch from 6169df0 to 0e05de5 Compare June 20, 2024 10:48
@emilysaffron emilysaffron merged commit bc589f9 into latest Jun 27, 2024
11 checks passed
@emilysaffron emilysaffron deleted the WSTEAM1-1018-input-fields-error-ux branch June 27, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants