WSTEAMA 1157 - Decommission Most Watched Page Delete Simorgh Code #11731

LilyL0u · 2024-06-17T15:30:04Z

Resolves JIRA [number]

Overall changes

A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.

Code changes

A bullet point list of key code changes that have been made.

Testing

List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

…his still happen?

LilyL0u · 2024-06-17T17:56:02Z

src/app/legacy/containers/StoryPromo/utilities/index.js

-    return 'h2';
-  }
-
+export const getHeadingTagOverride = ({ isContentTypeGuide }) => {


Hopefully editors will no longer put links to most watched in story promos (if this is what that is), as they will lonk to 404s but also they will not have the right heading or a11y attributes anymore.

LilyL0u · 2024-06-18T09:35:21Z

Note: if we change our mind and want the component actually not deleted, the last commit before I started deleting most watched component stuff is: 'remove most watched from bundle size tests'. So we can revert to here if we do change our minds.

LilyL0u · 2024-06-18T10:15:13Z

src/app/routes/utils/fetchPageData/index.test.js

@@ -13,8 +13,8 @@ import fetchPageData from '.';

 const expectedBaseUrl = 'http://localhost';
 const requestedPathname = '/path/to/asset';
-const fullTestPath = 'https://test.bbc.com/hausa/mostwatched.json';
-const fullLivePath = 'https://www.bbc.com/hausa/mostwatched.json';
+const fullTestPath = 'https://test.bbc.com/hausa/mostread.json';


The urls here don't actually matter if they work on test or live, the test just checks the correct url is passed through. So I could have left it as most watched, but it might confuse future people who see 'most watched' when that is no longer a thing

Technically most read paths don't exist either... but for the purposes of this test I suppose it doesn't matter? Or should we consider using a more bff-like path? e.g. https://test.mock-bff.api.bbc.com/simorgh-bff?pageType=bob?

I added that one :)

karinathomasbbc · 2024-06-19T08:53:16Z

.vscode/settings.json

Not sure if this file was supposed to be in version control?

karinathomasbbc · 2024-06-19T08:54:23Z

data/afaanoromoo/cpsAssets/oduu-41217768.json

@@ -320,8 +320,7 @@
    "secondaryData": {
      "topStories": null,
      "features": null,
-      "mostRead": null,
-      "mostWatched": null


This reminds me: we should also delete the mostWatched fetching from the BFF to truly clean this up

karinathomasbbc · 2024-06-19T08:59:54Z

src/app/lib/logger.const.js

-  MOST_WATCHED_PROCESS_ERROR: 'most_watched_process_error',
-  MOST_WATCHED_STALE_DATA: 'most_watched_stale_data',


We could potentially remove these queries from the Cloudwatch: https://github.com/bbc/simorgh-infrastructure/blob/latest/packages/cloudwatch-insights-queries/lib/index.ts#L288-L308

karinathomasbbc · 2024-06-19T09:00:58Z

src/app/pages/MediaAssetPage/MediaAssetPage.jsx

-  const MostWatchedWrapper = styled.div`
-    padding-bottom: ${GEL_SPACING_QUAD};
-  `;


This is likely to be the reason for the Chromatic diff - padding at the bottom that is no longer required 🙌

excellent, that's fine then :)

karinathomasbbc · 2024-06-19T09:01:46Z

src/app/routes/cpsAsset/getInitialData/index.js

@@ -128,14 +126,6 @@ export default async ({
      throw handleError('CPS asset data fetch error', status);
    }

-    const { mostWatched } = processMostWatched({


If you haven't already, can we make sure that this function is also deleted?

I can't find anything else left when I search 'processMostWatched', so hopefully I have

karinathomasbbc · 2024-06-19T09:03:18Z

src/app/routes/utils/fetchPageData/index.test.js

@@ -13,8 +13,8 @@ import fetchPageData from '.';

 const expectedBaseUrl = 'http://localhost';
 const requestedPathname = '/path/to/asset';
-const fullTestPath = 'https://test.bbc.com/hausa/mostwatched.json';
-const fullLivePath = 'https://www.bbc.com/hausa/mostwatched.json';
+const fullTestPath = 'https://test.bbc.com/hausa/mostread.json';


Technically most read paths don't exist either... but for the purposes of this test I suppose it doesn't matter? Or should we consider using a more bff-like path? e.g. https://test.mock-bff.api.bbc.com/simorgh-bff?pageType=bob?

karinathomasbbc · 2024-06-19T09:04:07Z

src/server/local/index.test.js

@@ -24,9 +24,6 @@ describe('Local Server', () => {
    ${'Migrated Home Page'}            | ${'/pidgin.json'}                                                | ${'/pidgin/homePage/index.json'}
    ${'Home Page'}                     | ${'/kyrgyz/tipohome.json'}                                       | ${'/kyrgyz/homePage/index.json'}
    ${'Most Read'}                     | ${'/pidgin/mostread.json'}                                       | ${'/pidgin/mostRead/index.json'}
-    ${'Most Read with variant'}        | ${'/zhongwen/mostread/trad.json'}                                | ${'/zhongwen/mostRead/trad.json'}


Did we mean to delete this?

Suggested change

${'Most Read with variant'} | ${'/zhongwen/mostread/trad.json'} | ${'/zhongwen/mostRead/trad.json'}

| ${'Most Read with variant'} | ${'/zhongwen/mostread/trad.json'} | ${'/zhongwen/mostRead/trad.json'}

oops no. Thanks.

…rgh-code' of github.com:bbc/simorgh into WSTEAMA-1157-decommission-most-watched-page-delete-simorgh-code

LilyL0u added 15 commits June 17, 2024 16:17

delete most watched routes folder

e9bb9b5

delete most watched regex in utils

2f26c8d

delete most watched regex reference

b3cd18a

might need to keep most watched data regex for component?

f3b4833

delete most watched page folder

95caed4

remove most wached page from bundlesize script

3751d09

remove most watched page from a11y page types

3570ddb

remove most watched page from ati analytics params

933ee50

remove most watched page from app routes index

d8948d4

remove most watched page constant in utils pageTypes

29b429f

remove most watched routes utils regex test

b905f74

remove most watched page export from pages _mocks_

107974f

remove export of MostWatchedPage in app pages

a1d3b08

remove most watched in ati chartbeat and event tracking

76620a8

remove most watched from story promo heading being h2 and test. can t…

999e7d5

…his still happen?

LilyL0u commented Jun 17, 2024

View reviewed changes

LilyL0u added 8 commits June 17, 2024 18:57

remove most watched a11y attributes from cps onward journey

068663c

remove most watched route test

a850d95

update obsolete snapshot

01b4d4b

isMostWatched boolean removed in most watched container

9d56601

remove most watched integration tests

71f577a

remove most watched from cypres config

d69fb67

remove most watched from readme folder map

63801b7

remove most watched from bundle size tests

33e54a3

LilyL0u marked this pull request as ready for review June 18, 2024 08:54

LilyL0u added 4 commits June 18, 2024 10:39

delete most watched page ati build params

85c70d0

delete most watched fixture data

80013c6

delete most watched container

4d00184

remove most watched from related content promo list

eb9dff8

LilyL0u added 11 commits June 18, 2024 10:51

remove getMostWatchedUrl

9fa6795

remove most watched from MAP

4249b1f

delete processMostWatched

42ce65b

remove most watched references in storyPage

84b9e0b

remove most watched from getInitialData

4525118

remove most watched from routes tests

69350d3

remove most watched from regex

66934f8

remove most watched models types

761b6df

remove most watched from constructDataFilePath

bf0623a

remove most watched from server local

de18a20

replace mostwatched with mostread in fetch data path test

e85d3f9

LilyL0u commented Jun 18, 2024

View reviewed changes

LilyL0u added 8 commits June 18, 2024 11:21

remove most watched from filterPopularStaleData

597ed7b

remove missed server local line of most watched path

136d3cd

remove most watched from services config

6b7752f

remove accidental image commit

10175c0

remove most watched toggles

0d2dabf

clean up unused vars

d06321b

some snapshot updates

ab98c34

remove most watched from fixture data

ca5a720

karinathomasbbc approved these changes Jun 19, 2024

View reviewed changes

LilyL0u and others added 5 commits June 20, 2024 10:09

replace test path with bff one

523146d

Delete .vscode/settings.json

a2a99fa

put back accidentally deleted most read

8a89fc0

Merge branch 'WSTEAMA-1157-decommission-most-watched-page-delete-simo…

b1a7dbd

…rgh-code' of github.com:bbc/simorgh into WSTEAMA-1157-decommission-most-watched-page-delete-simorgh-code

fix mistake

7a98327

louisearchibald approved these changes Jun 20, 2024

View reviewed changes

update snapshots

0b17ed1

LilyL0u merged commit a8fe552 into latest Jun 20, 2024
11 checks passed

LilyL0u deleted the WSTEAMA-1157-decommission-most-watched-page-delete-simorgh-code branch June 20, 2024 12:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WSTEAMA 1157 - Decommission Most Watched Page Delete Simorgh Code #11731

WSTEAMA 1157 - Decommission Most Watched Page Delete Simorgh Code #11731

LilyL0u commented Jun 17, 2024

LilyL0u Jun 17, 2024

LilyL0u commented Jun 18, 2024

LilyL0u Jun 18, 2024

karinathomasbbc Jun 19, 2024

LilyL0u Jun 20, 2024

karinathomasbbc Jun 19, 2024

LilyL0u Jun 19, 2024

LilyL0u Jun 20, 2024

karinathomasbbc Jun 19, 2024

karinathomasbbc Jun 19, 2024

karinathomasbbc Jun 19, 2024

LilyL0u Jun 19, 2024

karinathomasbbc Jun 19, 2024

LilyL0u Jun 19, 2024

karinathomasbbc Jun 19, 2024

karinathomasbbc Jun 19, 2024

LilyL0u Jun 19, 2024

LilyL0u Jun 20, 2024

		MOST_WATCHED_PROCESS_ERROR: 'most_watched_process_error',
		MOST_WATCHED_STALE_DATA: 'most_watched_stale_data',

	${'Most Read with variant'} \| ${'/zhongwen/mostread/trad.json'} \| ${'/zhongwen/mostRead/trad.json'}
	\| ${'Most Read with variant'} \| ${'/zhongwen/mostread/trad.json'} \| ${'/zhongwen/mostRead/trad.json'}

WSTEAMA 1157 - Decommission Most Watched Page Delete Simorgh Code #11731

WSTEAMA 1157 - Decommission Most Watched Page Delete Simorgh Code #11731

Conversation

LilyL0u commented Jun 17, 2024

Overall changes

Code changes

Testing

Helpful Links

Choose a reason for hiding this comment

LilyL0u commented Jun 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment