Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSTEAMA 1157 - Decommission Most Watched Page Delete Simorgh Code #11731

Merged
merged 52 commits into from
Jun 20, 2024
Merged

WSTEAMA 1157 - Decommission Most Watched Page Delete Simorgh Code #11731

Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
e9bb9b5
delete most watched routes folder
LilyL0u Jun 17, 2024
2f26c8d
delete most watched regex in utils
LilyL0u Jun 17, 2024
b3cd18a
delete most watched regex reference
LilyL0u Jun 17, 2024
f3b4833
might need to keep most watched data regex for component?
LilyL0u Jun 17, 2024
95caed4
delete most watched page folder
LilyL0u Jun 17, 2024
3751d09
remove most wached page from bundlesize script
LilyL0u Jun 17, 2024
3570ddb
remove most watched page from a11y page types
LilyL0u Jun 17, 2024
933ee50
remove most watched page from ati analytics params
LilyL0u Jun 17, 2024
d8948d4
remove most watched page from app routes index
LilyL0u Jun 17, 2024
29b429f
remove most watched page constant in utils pageTypes
LilyL0u Jun 17, 2024
b905f74
remove most watched routes utils regex test
LilyL0u Jun 17, 2024
107974f
remove most watched page export from pages _mocks_
LilyL0u Jun 17, 2024
a1d3b08
remove export of MostWatchedPage in app pages
LilyL0u Jun 17, 2024
76620a8
remove most watched in ati chartbeat and event tracking
LilyL0u Jun 17, 2024
999e7d5
remove most watched from story promo heading being h2 and test. can t…
LilyL0u Jun 17, 2024
068663c
remove most watched a11y attributes from cps onward journey
LilyL0u Jun 17, 2024
a850d95
remove most watched route test
LilyL0u Jun 17, 2024
01b4d4b
update obsolete snapshot
LilyL0u Jun 17, 2024
9d56601
isMostWatched boolean removed in most watched container
LilyL0u Jun 17, 2024
71f577a
remove most watched integration tests
LilyL0u Jun 17, 2024
d69fb67
remove most watched from cypres config
LilyL0u Jun 17, 2024
63801b7
remove most watched from readme folder map
LilyL0u Jun 17, 2024
33e54a3
remove most watched from bundle size tests
LilyL0u Jun 18, 2024
85c70d0
delete most watched page ati build params
LilyL0u Jun 18, 2024
80013c6
delete most watched fixture data
LilyL0u Jun 18, 2024
4d00184
delete most watched container
LilyL0u Jun 18, 2024
eb9dff8
remove most watched from related content promo list
LilyL0u Jun 18, 2024
9fa6795
remove getMostWatchedUrl
LilyL0u Jun 18, 2024
4249b1f
remove most watched from MAP
LilyL0u Jun 18, 2024
42ce65b
delete processMostWatched
LilyL0u Jun 18, 2024
84b9e0b
remove most watched references in storyPage
LilyL0u Jun 18, 2024
4525118
remove most watched from getInitialData
LilyL0u Jun 18, 2024
69350d3
remove most watched from routes tests
LilyL0u Jun 18, 2024
66934f8
remove most watched from regex
LilyL0u Jun 18, 2024
761b6df
remove most watched models types
LilyL0u Jun 18, 2024
bf0623a
remove most watched from constructDataFilePath
LilyL0u Jun 18, 2024
de18a20
remove most watched from server local
LilyL0u Jun 18, 2024
e85d3f9
replace mostwatched with mostread in fetch data path test
LilyL0u Jun 18, 2024
597ed7b
remove most watched from filterPopularStaleData
LilyL0u Jun 18, 2024
136d3cd
remove missed server local line of most watched path
LilyL0u Jun 18, 2024
6b7752f
remove most watched from services config
LilyL0u Jun 18, 2024
10175c0
remove accidental image commit
LilyL0u Jun 18, 2024
0d2dabf
remove most watched toggles
LilyL0u Jun 18, 2024
d06321b
clean up unused vars
LilyL0u Jun 18, 2024
ab98c34
some snapshot updates
LilyL0u Jun 18, 2024
ca5a720
remove most watched from fixture data
LilyL0u Jun 18, 2024
523146d
replace test path with bff one
LilyL0u Jun 20, 2024
a2a99fa
Delete .vscode/settings.json
LilyL0u Jun 20, 2024
8a89fc0
put back accidentally deleted most read
LilyL0u Jun 20, 2024
b1a7dbd
Merge branch 'WSTEAMA-1157-decommission-most-watched-page-delete-simo…
LilyL0u Jun 20, 2024
7a98327
fix mistake
LilyL0u Jun 20, 2024
0b17ed1
update snapshots
LilyL0u Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this file was supposed to be in version control?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"liveServer.settings.port": 5501
}
1 change: 0 additions & 1 deletion a11y.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ const pageTypes = {
],
photoGalleryPage: ["//div[@id='root']/header/nav/div/div[1]/div/ul"],
mostReadPage: ["//div[@id='root']/header/nav/div/div[1]/div/ul"],
mostWatchedPage: ["//div[@id='root']/header/nav/div/div[1]/div/ul"],
storyPage: [
"//div[@id='root']/header/nav/div/div[1]/div/ul",
'/iframe', // same issues as in mediaEmbedErrorsToSuppress but the DOM path is different
Expand Down
Loading
Loading