Remove skip on optimizely hindi experiment tests #9988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoore108
previously approved these changes
Mar 25, 2022
HarveyPeachey
previously approved these changes
Mar 28, 2022
MuhammadAHussain
dismissed stale reviews from HarveyPeachey and amoore108
Fixed broken test by mocking implementation.
amoore108
reviewed
Mar 29, 2022
amoore108
approved these changes
Mar 29, 2022
HarveyPeachey
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #N/A
Overall change:
Tests were skipped and the mocking of OptimizelyExperiment was broken. Removed the skip and fixed the tests.
Code changes:
jest.mockinstead ofjest.spyOn.cross-teamlabel to this PR if it requires visibility across World Service teamsTesting:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)