Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seem to be missing legend? #6

Closed
jacobhurst opened this issue Feb 26, 2015 · 5 comments
Closed

Seem to be missing legend? #6

jacobhurst opened this issue Feb 26, 2015 · 5 comments
Labels

Comments

@jacobhurst
Copy link

Think, I've got it running ok but the legend does not appear to be there when I select an area with the mouse?

i also had to change the reference in package.json to biojs-sniper to sniper? i used npm to install.

screenshot from 2015-02-26 17 09 53

@mpschr
Copy link
Contributor

mpschr commented Feb 27, 2015

Hi @jacobhurst

Thanks for reporting!

The biojs-sniper should be working fine. But the dependency was missing until recently from the non-developer dependencies. (see this commit: https://github.com/bbglab/muts-needle-plot/blob/4468fe7c5ef13c67a680e40e1e002441a94d8454/package.json).

About the legend: It's hard to tell what is goin wrong there. Could you access the chrome or firefox console and see if there is any error message?

Cheers

@jacobhurst
Copy link
Author

Hi @mpschr
Thanks for making your code available! Looking in the console it can't see D3...

screenshot from 2015-02-27 10 20 52

DIR:.
url /
url /build/muts-needle-plot.css
url /build/muts-needle-plot.js
url /src/js/dependencies/d3.js
url /snippets/data/muts.json
url /snippets/data/regions.json

seems to load the d3 here...
cheers

@mpschr mpschr added the bug label Mar 2, 2015
@mpschr
Copy link
Contributor

mpschr commented Mar 2, 2015

Hi,

Here it tries to use the code in the file: src/js/d3-svg-legend.js and for some reason it is not loaded. Is it missing from the dependencies? I mean, can you see in the HTML if it is being loaded?

A couple of other questions:

  • Is there the same error for all the examples?
  • Did you follow the npm-installation guide in the README?

I just followed the npm-installation guide and it seemed to work fine

@jacobhurst
Copy link
Author

The npm install does not work for me, from my history file:-

2004 sudo npm install -g npm
2005 npm run sniper
2006 cd muts-needle-plot/
2007 npm run sniper
2008 sudo npm install -g sniper
2009 npm run sniper

It then fails on:-

[03-03-15 09:39:20 l: 1.47] $> npm run sniper

muts-needle-plot@0.8.0 sniper /home/jacobhurst/play/node_modules/muts-needle-plot
biojs-sniper .

sh: 1: biojs-sniper: not found

@mpschr
Copy link
Contributor

mpschr commented Mar 3, 2015

Try installing with npm install biojs-sniper

Anyhow, I was able to install and run the plot with these three commands (I don't know what the -g option does)

  • npm install muts-needle-plot
  • cd node_modules/muts-needle-plot
  • npm run sniper

The biojs-sniper should be installed automatically. If not, try to install it afterwards with the command on the first line.

@mpschr mpschr closed this as completed Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants