Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick changes #50

Closed
6 tasks done
mcuadros opened this issue Sep 19, 2017 · 4 comments · Fixed by #51
Closed
6 tasks done

Quick changes #50

mcuadros opened this issue Sep 19, 2017 · 4 comments · Fixed by #51
Assignees

Comments

@mcuadros
Copy link
Contributor

mcuadros commented Sep 19, 2017

  • Decrease font size a 20%
  • Move the "RUN Parser" to tthe right of screen
  • Add more example to the example combo:
  • Use the same font in the text are and the tree: http://sourcefoundry.org/hack/
  • Remove the "Driver code" label from the octocat icon, and put "Driver repository" as an alt desc
  • Changes the example with the following files:

Name: fizzbuzz.py

def fizzbuzz(n):

    if n % 3 == 0 and n % 5 == 0:
        return 'FizzBuzz'
    elif n % 3 == 0:
        return 'Fizz'
    elif n % 5 == 0:
        return 'Buzz'
    else:
        return str(n)

print "\n".join(fizzbuzz(n) for n in xrange(1, 21))

Name: classdef.py
https://github.com/bblfsh/python-driver/blob/master/tests/classdef.py.source

Name: hello.java

// hello.java
import java.io.*;
import javax.servlet.*;

public class Hello extends GenericServlet {
    public void service(final ServletRequest request, final ServletResponse response)
    throws ServletException, IOException {
        response.setContentType("text/html");
        final PrintWriter pw = response.getWriter();
        try {
            pw.println("Hello, world!");
        } finally {
            pw.close();
        }
    }
}

Name: swap.java

public class SwapElementsExample {
 
        public static void main(String[] args) {
               
                int num1 = 10;
                int num2 = 20;
               
                System.out.println("Before Swapping");
                System.out.println("Value of num1 is :" + num1);
                System.out.println("Value of num2 is :" +num2);
               
                //swap the value
                swap(num1, num2);
        }
 
        private static void swap(int num1, int num2) {
               
                int temp = num1;
                num1 = num2;
                num2 = temp;
               
                System.out.println("After Swapping");
                System.out.println("Value of num1 is :" + num1);
                System.out.println("Value of num2 is :" +num2);
               
        }
}
@dpordomingo
Copy link
Member

On it.
I'll mark each subtask as "done" when it is ready in my dev machine, and I'll close the issue when the PR #51 is merged

@dpordomingo
Copy link
Member

as requested irl, I'll add to the changes:

  • Remove the "Driver code" label from the octocat icon, and put "Driver repository" as an alt desc

@dpordomingo
Copy link
Member

dpordomingo commented Sep 19, 2017

@mcuadros PR #51 is ready to review

@dpordomingo
Copy link
Member

Merged and shipped into the new release https://github.com/bblfsh/dashboard/releases/tag/v0.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants