Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance error when clicking in some tokens #54

Closed
dpordomingo opened this issue Sep 20, 2017 · 2 comments
Closed

Performance error when clicking in some tokens #54

dpordomingo opened this issue Sep 20, 2017 · 2 comments
Assignees
Labels

Comments

@dpordomingo
Copy link
Member

as reported by @vmarkovtsev vía Slack:

I found a bug. Open fizzbuzz.py and click on "return" in "return 'Buzz'". It freezes and kills the tab

Diagnostic:

There is a performance error when clicking in some tokens, that causes a browser tab freeze.

given the following python sourcecode:

def fizzbuzz(n):
    if false:
        return 'Fizz'
    else:
        return 'FizzBuzz'

click in the last return -> small freeze
click in FizzBuzz -> looooong freeze

@dpordomingo dpordomingo self-assigned this Sep 20, 2017
@dpordomingo
Copy link
Member Author

dpordomingo commented Sep 20, 2017

I spotted the merge causing the problem:
https://github.com/bblfsh/dashboard/pull/19/files
It was added to (recursively) uncollapse a highlited node.

@dpordomingo
Copy link
Member Author

It does not depend on the language;
It depends on the complexity of the source code -> deepness of the UAST.
It's more likely to occur when the clicked token is really deep in the UAST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant