Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace crack with nokogiri? #1048

Closed
andyw8 opened this issue Jan 26, 2024 · 4 comments
Closed

Replace crack with nokogiri? #1048

andyw8 opened this issue Jan 26, 2024 · 4 comments

Comments

@andyw8
Copy link

andyw8 commented Jan 26, 2024

The latest release of crack was over 3 years ago, and there are unresolved issues with Ruby 3.3, such as jnunemaker/crack#75.

Would you consider a PR which switches to Nokogiri instead for XML parsing?

@andyw8 andyw8 changed the title is:issue is:open Replace crack with nokogiri? Replace crack with nokogiri? Jan 26, 2024
@andyw8
Copy link
Author

andyw8 commented Jan 26, 2024

Alternatively, the very small implementation could just be copied into the WebMock codebase.

@kiskoza
Copy link

kiskoza commented Jan 29, 2024

We just released a new crack version fixing the compability issues, let me know if you need anything else for that gem. (Also, I'm not against dropping crack from webmock if you choose that path)

@bblimke
Copy link
Owner

bblimke commented Feb 6, 2024

@andyw8 thank you for reporting the issue.

@kiskoza thank you for the rapid response and releasing the new version :)

If crack is still being maintained, I don't see any reason to replace it with copied implementation or heavyweight nokogiri.

@kiskoza do ever you plan to do a 1.x release of crack?

@kiskoza
Copy link

kiskoza commented Feb 6, 2024

I'm open to release a v1 if there's a need for it, let's have a discussion on jnunemaker/crack#63

@andyw8 andyw8 closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants